🌐 Add pt-BR language #135
🌐 Add pt-BR language #135
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @P3terHenry, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello! Gemini-code-assist here, providing a summary of this pull request to help everyone get up to speed quickly. This PR, authored by P3terHenry, aims to add support for the Brazilian Portuguese language (pt-BR) to the application. This involves adding the locale to the list of available languages and providing the translated descriptions for the gitmojis.
Highlights
- New Language Support: Adds Brazilian Portuguese (pt-BR) as a supported language for the gitmoji descriptions.
- Translation File Added: Includes a new YAML file containing the complete set of gitmoji descriptions translated into Brazilian Portuguese.
Changelog
- src/main/kotlin/com/github/patou/gitmoji/GitmojiLocale.kt
- Added "pt_BR" to the
LANGUAGE_CONFIG_LISTarray on line 13, making Brazilian Portuguese selectable in the application.
- Added "pt_BR" to the
- src/main/resources/gitmojis-pt_BR.yaml
- Added a new file containing the Brazilian Portuguese translations for all gitmoji descriptions.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
New language arrives,
Emojis speak Portuguese now,
Code welcomes the world.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
Thank you for this contribution! Adding Portuguese (Brazil) translations is a great enhancement for users in that region. The changes are well-structured and follow the existing patterns for localization in this project. 🇧🇷🚀
The addition of pt_BR to the language configuration list and the new gitmojis-pt_BR.yaml file with translations look good from a technical perspective. The new YAML file is well-formed and appears to cover all the necessary gitmoji descriptions.
Summary of Findings
- YAML String Quoting Consistency: In
gitmojis-pt_BR.yaml, some string values that correspond to quoted strings in the basegitmojis.yaml(English) or other translation files (e.g., French for thetruckkey) are not quoted. For example,truck: Mover ou renomear recursos (ex.: arquivos, caminhos, rotas).. While YAML often doesn't require quotes for simple strings, maintaining consistency with the source or other translations could be considered for future updates across all translation files. However, since other existing translations (e.g., Russian, Chinese) also omit quotes for this key, this is a very minor point of overall consistency rather than an issue specific to this PR. This is alowseverity observation and, per review settings, is not raised as a direct comment requiring changes.
Merge Readiness
From a technical and structural standpoint, this pull request appears to be in good shape and ready for merging. The code changes are straightforward and correctly implement the addition of the new language. As I am not a native Portuguese speaker, I cannot vouch for the linguistic accuracy of the translations, but assuming they are correct, the PR is good to go. I am not authorized to approve pull requests, so please ensure it undergoes any further necessary review, particularly for translation accuracy if required, before merging.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #135 +/- ##
========================================
Coverage ? 0.00%
========================================
Files ? 12
Lines ? 301
Branches ? 49
========================================
Hits ? 0
Misses ? 301
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@patou Can you check and release the new version with pt-br? I think the Codecov bot is showing an error and requesting review, but there is nothing to review or fix. |
|
@P3terHenry |
3 participants
Good day! 😊
This is a translation of the emoji descriptions into Portuguese (Brazil).
Let me know if anything needs to be adjusted!
Thank you for the awesome plugin 🚀