Skip to content

Added external repos in Examples#947

Merged
patrick-kidger merged 2 commits intopatrick-kidger:mainfrom
TugdualKerjan:main
Feb 15, 2025
Merged

Added external repos in Examples#947
patrick-kidger merged 2 commits intopatrick-kidger:mainfrom
TugdualKerjan:main

Conversation

@TugdualKerjan
Copy link
Contributor

Based on the discussion on #936 - I seperated the notebooks from the external repos, and added some projects from the awesome list mentionned - is this how you saw things ?

@patrick-kidger
Copy link
Owner

Ah, awesome!
So my guess is that having the list of these projects live in the sidebar is going to get quite unwieldy as we add to this list. (And there's quite a few other external projects I know of that I'd like to add here!)

For that reason I'm thinking it might be easier to put them on a single page, and then have that page somewhere prominent in the sidebar. Maybe something like:

# mkdocs.yml

nav:
    ...
    - Examples:
        - Introductory: 
            ...
        - Advanced:
            ...
        - Features:
            ...
        - Awesome list: 'examples/awesome-list.md'

# awesome-list.md

Details here!

WDYT?

@TugdualKerjan
Copy link
Contributor Author

definetly agree - changes made with a short description to make it a little bit clearer what each project points to etc !

tell me if anything needs changing on my part 👍

@patrick-kidger patrick-kidger merged commit aa57716 into patrick-kidger:main Feb 15, 2025
1 check passed
@patrick-kidger
Copy link
Owner

patrick-kidger commented Feb 15, 2025

LGTM! Merged :) I'm very happy to have this in (and I'm about to add a few more projects to it :) )

@TugdualKera
Copy link

Thanks !!! This is my first PR ever :) Won't be my last !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants