Add fp4e2m1fn type.#353
Merged
patrick-kidger merged 2 commits intopatrick-kidger:mainfrom Nov 15, 2025
Merged
Conversation
Owner
|
Looks reasonable to me! Happy to merge this. Looks like the pre-commits are failing, see CONTRIBUTING.md for setting that up :) |
Contributor
Author
|
Hi Patrick, thanks for looking at this cl. The test flow described in CONTRIBUTING.md are passing. It looks like the issue is ruff code formatting. I've ran ruff format offline and updated the changes. |
Owner
|
Merged! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds fp4e2m1fn datatype from Jax https://github.com/jax-ml/jax/blob/main/jax/_src/dtypes.py#L111-L114, PR jax-ml/jax#26525.