Qt6: port to Qt6 - C++ part#20
Qt6: port to Qt6 - C++ part#20moodyhunter wants to merge 1 commit intopatrickelectric:masterfrom moodyhunter:master
Conversation
| import QtQuick.Layouts 1.3 | ||
|
|
||
| // Qt6! Use 'Qt.labs.platform' instead of 'QtQuick.Dialogs' | ||
| //import Qt.labs.platform 1.0 |
There was a problem hiding this comment.
Hi, just a simple question, this Qt6! is a especial tag for the compiler/interpreter or just a comment ?
Other than that the patch looks fine, but I'll probably have the master branch for Qt6 and create a separated branch for Qt5.
There was a problem hiding this comment.
Oh, I've seen this type of comment in some other projects, and just followed their rule.
It doesn't have a special meaning but makes the future search easier (like the keywords "// TODO" or "// WARNING")
|
Hi @moodyhunter, any update on this ? I'm planning to do it this year otherwise |
|
I haven't been working on these Qt things recently, so there won't be future updates. Do feel free to merge this PR if you think it's fine, otherwise closing it would be fine :) |
|
Thanks @moodyhunter, I'm doing the update to Qt6, the code works, has some warnings, but I'm closing up now the build system. Thanks for the PR, I'll check pick some commits if necessary. |
This PR tries to port QHot to Qt6, with:
Limitations:
QtQuick.Dialog :: FileDialoghas been moved toQt.labs.platform(Available since Qt 5.8)fileUrlproperty is now namedfileQtGraphicalEffectsis removed, may needQt5Compatto import it backChanges:
Added a CMake option
QHOT_USE_QT6which defaults toOFFUsed
${QT_VERSION_MAJOR}in CMaketarget_link_librariesandget_target_propertywhich will be set to 5 or 6 accordingly.Removed command line option
scalingandno-scalingsince HiDPI scales are always enabled in Qt6.