Skip to content

Add module-info via moditect #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add module-info via moditect #64

wants to merge 1 commit into from

Conversation

bowbahdoe
Copy link

@bowbahdoe bowbahdoe commented Nov 25, 2023 •
edited
Loading

Addresses #63

Before:

> jlink -p target/bytes-1.6.2.jar --add-modules at.favre.lib.bytes --output jre

Error: automatic module cannot be used with jlink: at.favre.lib.bytes from file:///Users/emccue/Development/bytes-java/target/bytes-1.6.2.jar

After:

> jlink -p target/bytes-1.6.2.jar --add-modules at.favre.lib.bytes --output jre
> ./jre/bin/java --list-modules
[email protected]
[email protected]
[email protected]

@bowbahdoe
Copy link
Author

@patrickfav Do you have any time to get around to this? I'll send you a 🍕 if you give me a venmo or an address to send it to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bowbahdoe