Skip to content

fix empty ember template lint config page if package cannot be found #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

fix empty ember template lint config page if package cannot be found #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/main/kotlin/com/emberjs/hbs/linter/ember-template-lint/TemplateLintConfiguration.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,10 @@ class TemplateLintConfiguration(project: Project) : JSLinterConfiguration<Templa

override fun loadPrivateSettings(state: TemplateLintState): TemplateLintState {
this.myPackage.readOrDetect()
val constantPackage = myPackage.getPackage().constantPackage
?: throw AssertionError("TemplateLint does not support non-constant node package refs")

return state.copy(
myInterpreterRef = this.myPackage.interpreter,
myTemplateLintPackage = constantPackage
myTemplateLintPackage = this.myPackage.getPackage().constantPackage
)
}

Expand Down
8 changes: 4 additions & 4 deletions src/main/kotlin/com/emberjs/hbs/linter/ember-template-lint/TemplateLintState.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ import com.intellij.lang.javascript.linter.JSNpmLinterState

data class TemplateLintState(
private val myInterpreterRef: NodeJsInterpreterRef,
private val myTemplateLintPackage: NodePackage,
private val myTemplateLintPackage: NodePackage?,
val isRunOnSave: Boolean,
) : JSNpmLinterState<TemplateLintState> {

private val myPackageRef: NodePackageRef = NodePackageRef.create(myTemplateLintPackage)
private val myPackageRef: NodePackageRef? = myTemplateLintPackage?.let { NodePackageRef.create(it) }

override fun withLinterPackage(packageRef: NodePackageRef): TemplateLintState {
val constantPackage = packageRef.constantPackage
Expand All @@ -24,12 +24,12 @@ data class TemplateLintState(
}

override fun getNodePackageRef(): NodePackageRef {
return this.myPackageRef
return this.myPackageRef!!
}

val templateLintPackage: NodePackage
get() {
return this.myTemplateLintPackage
return this.myTemplateLintPackage!!
}

companion object {
Expand Down
Loading