fix(lint): Manually resolve final lint issues

Author: bmuenzenmeyer

core/lib/annotation_exporter.js

@@ -35,7 +35,8 @@ const annotations_exporter = function(pl) {
     oldAnnotations = oldAnnotations.replace('};', '}');
 
     try {
-      var oldAnnotationsJSON = JSON.parse(oldAnnotations);
+      const oldAnnotationsJSON = JSON.parse(oldAnnotations);
+      return oldAnnotationsJSON.comments;
     } catch (ex) {
       logger.error(
         `There was an error parsing JSON for ${
@@ -44,7 +45,6 @@ const annotations_exporter = function(pl) {
       );
       return [];
     }
-    return oldAnnotationsJSON.comments;
   }
 
   /**

core/lib/exportData.js

@@ -2,7 +2,6 @@
 
 const eol = require('os').EOL;
 const path = require('path');
-const _ = require('lodash');
 
 const ae = require('./annotation_exporter');
 

core/lib/get.js

@@ -4,33 +4,33 @@ const logger = require('./log');
 
 module.exports = function(partialName, patternlab) {
   //look for exact partial matches
-  for (var i = 0; i < patternlab.patterns.length; i++) {
+  for (let i = 0; i < patternlab.patterns.length; i++) {
     if (patternlab.patterns[i].patternPartial === partialName) {
       return patternlab.patterns[i];
     }
   }
 
   //else look by verbose syntax
-  for (var i = 0; i < patternlab.patterns.length; i++) {
+  for (let j = 0; j < patternlab.patterns.length; j++) {
     switch (partialName) {
-      case patternlab.patterns[i].relPath:
-        return patternlab.patterns[i];
-      case patternlab.patterns[i].verbosePartial:
-        return patternlab.patterns[i];
+      case patternlab.patterns[j].relPath:
+        return patternlab.patterns[j];
+      case patternlab.patterns[j].verbosePartial:
+        return patternlab.patterns[j];
     }
   }
 
   //return the fuzzy match if all else fails
-  for (var i = 0; i < patternlab.patterns.length; i++) {
-    let partialParts = partialName.split('-'),
-      partialType = partialParts[0],
-      partialNameEnd = partialParts.slice(1).join('-');
+  for (let k = 0; k < patternlab.patterns.length; k++) {
+    const partialParts = partialName.split('-');
+    const partialType = partialParts[0];
+    const partialNameEnd = partialParts.slice(1).join('-');
 
     if (
-      patternlab.patterns[i].patternPartial.split('-')[0] === partialType &&
-      patternlab.patterns[i].patternPartial.indexOf(partialNameEnd) > -1
+      patternlab.patterns[k].patternPartial.split('-')[0] === partialType &&
+      patternlab.patterns[k].patternPartial.indexOf(partialNameEnd) > -1
     ) {
-      return patternlab.patterns[i];
+      return patternlab.patterns[k];
     }
   }
   logger.warning(

core/lib/loadPattern.js

@@ -114,8 +114,9 @@ module.exports = function(relPath, patternlab) {
   }
 
   //look for a json file for this template
+  let jsonFilename;
   try {
-    var jsonFilename = path.resolve(
+    jsonFilename = path.resolve(
       patternsPath,
       currentPattern.subdir,
       currentPattern.fileName
@@ -136,8 +137,9 @@ module.exports = function(relPath, patternlab) {
   }
 
   //look for a listitems.json file for this template
+  let listJsonFileName;
   try {
-    var listJsonFileName = path.resolve(
+    listJsonFileName = path.resolve(
       patternsPath,
       currentPattern.subdir,
       currentPattern.fileName + '.listitems'

core/lib/parseLink.js

@@ -6,19 +6,18 @@ const logger = require('./log');
 const getPartial = require('./get');
 
 module.exports = function(patternlab, obj, key) {
-  let linkRE, dataObjAsString, linkMatches;
-
   //check for 'link.patternPartial'
-  linkRE = /(?:'|")(link\.[A-z0-9-_]+)(?:'|")/g;
+  const linkRE = /(?:'|")(link\.[A-z0-9-_]+)(?:'|")/g;
 
   //stringify the passed in object
+  let dataObjAsString;
   dataObjAsString = JSON.stringify(obj);
   if (!dataObjAsString) {
     return obj;
   }
 
   //find matches
-  linkMatches = dataObjAsString.match(linkRE);
+  const linkMatches = dataObjAsString.match(linkRE);
 
   if (linkMatches) {
     for (let i = 0; i < linkMatches.length; i++) {

core/lib/plugin_manager.js

@@ -26,8 +26,9 @@ const plugin_manager = function(config, configPath) {
         path.join(process.cwd(), 'node_modules', pluginName)
       );
       logger.debug(`Attempting to load plugin from ${pluginPath}`);
+      let pluginDirStats;
       try {
-        var pluginDirStats = fs.statSync(pluginPath);
+        pluginDirStats = fs.statSync(pluginPath);
       } catch (ex) {
         logger.warning(`${pluginName} not found, use npm to install it first.`);
         logger.warning(`${pluginName} not loaded.`);

core/lib/pseudopattern_hunter.js

@@ -38,12 +38,14 @@ pseudopattern_hunter.prototype.find_pseudopatterns = function(
       );
 
       //we want to do everything we normally would here, except instead read the pseudoPattern data
+      let variantFileFullPath;
+      let variantFileData;
       try {
-        var variantFileFullPath = path.resolve(
+        variantFileFullPath = path.resolve(
           paths.source.patterns,
           pseudoPatterns[i]
         );
-        var variantFileData = fs.readJSONSync(variantFileFullPath);
+        variantFileData = fs.readJSONSync(variantFileFullPath);
       } catch (err) {
         logger.warning(
           `There was an error parsing pseudopattern JSON for ${

core/lib/starterkit_manager.js

@@ -24,8 +24,9 @@ const starterkit_manager = function(config) {
         )
       );
       logger.debug('Attempting to load starterkit from', kitPath);
+      let kitDirStats;
       try {
-        var kitDirStats = fs.statSync(kitPath);
+        kitDirStats = fs.statSync(kitPath);
       } catch (ex) {
         logger.warning(
           `${starterkitName} not found, use npm to install it first.`