Skip to content

docs: update documentation side bar nav organization #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rebeccaalpert merged 4 commits into from
Nov 14, 2024
Merged

docs: update documentation side bar nav organization #310

rebeccaalpert merged 4 commits into from
Nov 14, 2024

Conversation

@nicolethoen
Copy link
Contributor

@nicolethoen nicolethoen commented Nov 12, 2024 •
edited
Loading

Closes #300
Closes #282

@patternfly-build
Copy link

patternfly-build commented Nov 12, 2024 •
edited
Loading

Preview: https://virtual-assistant-pr-virtual-assistant-310.surge.sh

A11y report: https://virtual-assistant-pr-virtual-assistant-310-a11y.surge.sh

rebeccaalpert
rebeccaalpert approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we want to make the modals, attachment error, and attachment dropzone part of the UI section. Same with the attachment label - we use the attachment label as part of messages, but also in the footer. We don't have a demo that explicitly demonstrates this, but I can add one in a separate PR after this merges.

We're also going to have to fix all the links - pretty much every link is broken now. I'd be happy to merge this and then fix them on my side if that's helpful.

@nicolethoen
Copy link
Contributor Author

nicolethoen commented Nov 12, 2024

Ah i didn't think to check the links. I can definitely do that as part of this.

@nicolethoen
Copy link
Contributor Author

nicolethoen commented Nov 13, 2024

@rebeccaalpert updated the links 👍🏻 and rebased

rebeccaalpert
rebeccaalpert suggested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the links. It looks like a few more broke during the rebase - I added suggestions for those.

rebeccaalpert
rebeccaalpert approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me! Thanks for fixing those links.

@rebeccaalpert rebeccaalpert merged commit 9b1ed94 into patternfly:main Nov 14, 2024
@github-actions
Copy link

github-actions bot commented Nov 14, 2024

🎉 This PR is included in version 2.1.0-prerelease.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

edonehoo pushed a commit to edonehoo/chatbot that referenced this pull request Nov 20, 2024
@nicolethoen @rebeccaalpert @edonehoo
docs: update documentation side bar nav organization (patternfly#310)
64fefbe 
* docs: update documentation side bar nav organization

* rebase and regenerate screenshots for new example

* Update packages/module/patternfly-docs/content/extensions/virtual-assistant/examples/demos/Chatbot.md

Co-authored-by: Rebecca Alpert <[email protected]>

* Update packages/module/patternfly-docs/content/extensions/virtual-assistant/examples/UI/UI.md

Co-authored-by: Rebecca Alpert <[email protected]>

---------

Co-authored-by: Rebecca Alpert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edonehoo edonehoo Awaiting requested review from edonehoo

1 more reviewer

@rebeccaalpert rebeccaalpert rebeccaalpert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Demo: Update demo to open chatbot by default. Pull out demos to a more discoverable location in docs

3 participants

@nicolethoen @patternfly-build @rebeccaalpert