feat(Message): Allow for multiple attachments #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolethoen
reviewed
Nov 18, 2024
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
Is any extra note needed for explaining how to enable uploading multiple attachments? None of the examples allow for it, so I cannot test the API, but even just explaining how to wire up the intended behavior would be helpful for me to test.
Member
Author
|
I'm doing it here, but I can added a note about the API. https://github.com/patternfly/virtual-assistant/blob/main/packages/module/patternfly-docs/content/extensions/virtual-assistant/examples/demos/ChatbotAttachment.tsx#L110 |
nicolethoen
approved these changes
Nov 19, 2024
|
🎉 This PR is included in version 2.1.0-prerelease.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a breaking change, but none of our consumers are using attachments yet. I'd be happy to put back the old API if we need to maintain it.