-
Notifications
You must be signed in to change notification settings - Fork 34
feat(ChatBotFooter/MessageBar): Add white background variants #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview: https://chatbot-pr-chatbot-690.surge.sh A11y report: https://chatbot-pr-chatbot-690-a11y.surge.sh |
0555b9c to
cda10eb
Compare
edonehoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lmk what you think about these thoughts! 🧠
packages/module/patternfly-docs/content/extensions/chatbot/examples/demos/Chatbot.md
Outdated
Show resolved
Hide resolved
|
|
||
| ### Embedded ChatBot with Primary Background | ||
|
|
||
| This demo displays an embedded ChatBot with a primary background color. Embedded ChatBots are meant to be placed within a page in your product. This demo includes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This demo displays an embedded ChatBot with a primary background color. Embedded ChatBots are meant to be placed within a page in your product. This demo includes: | |
| This demo displays an embedded ChatBot with a [primary background color](/design-foundations/colors#background-colors). This example includes the same features as the [Embedded ChatBot demo](/patternfly-ai/chatbot/overview/demo/#embedded-chatbot)—the only difference is that the background color is made adjusted via the `isPrimary` prop. You can use the same logic to adjust the background color in any ChatBot layout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wdyt about replacing the description just with this simple block, so that the focus is on what's unique in this demo? do you think it'll be confusing / cuts anything vital out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just edited it a little bit to mention that some sample messages are different - let me know if you don't want that there or want it phrased differently!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yep that totally makes sense! didn't notice that, ty!
left a small comment to finalize, but this looks good to go otherwise
packages/module/patternfly-docs/content/extensions/chatbot/examples/demos/Chatbot.md
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/demos/Chatbot.md
Show resolved
Hide resolved
2fe0d76 to
3205ab2
Compare
|
All set @edonehoo! Thank you. |
packages/module/patternfly-docs/content/extensions/chatbot/examples/demos/Chatbot.md
Show resolved
Hide resolved
|
All set @edonehoo! |
Request from OpenShift AI since they have more complex embedded layouts.
…mples/demos/Chatbot.md Co-authored-by: Erin Donehoo <[email protected]>
808ed28 to
c606aa9
Compare
|
🎉 This PR is included in version 6.5.0-prerelease.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…nfly#690) Request from OpenShift AI since they have more complex embedded layouts. Co-authored-by: Erin Donehoo <[email protected]>
Request from OpenShift AI since they have more complex embedded layouts.
White chatbot will flow into demo once that PR merges - includes the prop. Will update screenshot once we do that.
https://chatbot-pr-chatbot-690.surge.sh/patternfly-ai/chatbot/overview/demo#embedded-chatbot-with-primary-background