Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 41 additions & 41 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"@babel/preset-react": "^7.23.3",
"@babel/preset-typescript": "^7.23.3",
"@octokit/rest": "^18.0.0",
"@patternfly/documentation-framework": "6.22.7",
"@patternfly/documentation-framework": "6.28.6",
"@patternfly/patternfly": "^6.1.0",
"@patternfly/react-icons": "^6.1.0",
"@patternfly/react-table": "^6.1.0",
Expand Down
36 changes: 18 additions & 18 deletions packages/module/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,49 +33,49 @@
"tag": "prerelease"
},
"dependencies": {
"@patternfly/react-core": "^6.1.0",
"@patternfly/react-code-editor": "^6.1.0",
"@patternfly/react-core": "^6.1.0",
"@patternfly/react-icons": "^6.1.0",
"@patternfly/react-table": "^6.1.0",
"@segment/analytics-next": "^1.76.0",
"posthog-js": "^1.194.4",
"clsx": "^2.1.0",
"path-browserify": "^1.0.1",
"posthog-js": "^1.194.4",
"react-markdown": "^9.0.1",
"remark-gfm": "^4.0.0",
"rehype-unwrap-images": "^1.0.0",
"rehype-external-links": "^3.0.0",
"rehype-sanitize": "^6.0.0",
"path-browserify": "^1.0.1",
"rehype-unwrap-images": "^1.0.0",
"remark-gfm": "^4.0.0",
"unist-util-visit": "^5.0.0"
},
"peerDependencies": {
"react": "^18 || ^19",
"react-dom": "^18 || ^19"
},
"devDependencies": {
"@patternfly/documentation-framework": "6.22.7",
"@octokit/rest": "^18.0.0",
"@patternfly/documentation-framework": "6.28.6",
"@patternfly/patternfly": "^6.1.0",
"@patternfly/patternfly-a11y": "^5.0.0",
"@types/dom-speech-recognition": "^0.0.4",
"@types/react": "^18.2.61",
"estree-util-is-identifier-name": "^3.0.0",
"file-saver": "^2.0.5",
"rimraf": "^2.7.1",
"typescript": "^5.3.3",
"@octokit/rest": "^18.0.0",
"unified": "^11.0.5",
"victory-bar": "^37.1.1",
"victory-core": "^37.1.1",
"victory-scatter": "^37.1.1",
"victory-pie": "^37.1.1",
"victory-stack": "^37.1.1",
"victory-legend": "^37.1.1",
"victory-line": "^37.1.1",
"victory-group": "^37.1.1",
"victory-voronoi-container": "^37.1.1",
"victory-create-container": "^37.1.1",
"victory-cursor-container": "^37.1.1",
"victory-group": "^37.1.1",
"victory-legend": "^37.1.1",
"victory-line": "^37.1.1",
"victory-pie": "^37.1.1",
"victory-scatter": "^37.1.1",
"victory-stack": "^37.1.1",
"victory-tooltip": "^37.1.1",
"victory-bar": "^37.1.1",
"file-saver": "^2.0.5",
"unified": "^11.0.5",
"estree-util-is-identifier-name": "^3.0.0"
"victory-voronoi-container": "^37.1.1"
},
"overrides": {
"puppeteer": "^23.6.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export const AttachmentMenuExample: FunctionComponent = () => {
// eslint-disable-next-line no-console
onSelect={(_ev, value) => console.log('selected', value)}
handleTextInputChange={onTextChange}
popperProps={{ direction: 'up', distance: '8' }}
popperProps={{ direction: 'up', distance: 8 }}
searchInputPlaceholder="Search cluster resources..."
toggle={(toggleRef) => (
<Button
Expand Down
8 changes: 2 additions & 6 deletions packages/module/src/AttachMenu/AttachMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,9 @@
DropdownProps,
Dropdown,
DropdownToggleProps,
DropdownPopperProps
PopperOptions
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jackson consolidated these in PF React - this flows in the type change that he made there.

} from '@patternfly/react-core';

export interface ExtendedDropdownPopperProps extends DropdownPopperProps {
distance: string;
}

export interface AttachMenuProps extends DropdownProps {
/** Items in menu */
filteredItems: React.ReactNode;
Expand All @@ -26,7 +22,7 @@
/** Flag to indicate if menu is opened. */
isOpen: boolean;
/** Additional properties to pass to the Popper */
popperProps?: ExtendedDropdownPopperProps;
popperProps?: PopperOptions;
/** Callback to change the open state of the menu. Triggered by clicking outside of the menu. */
onOpenChange: (isOpen: boolean) => void;
/** Keys that trigger onOpenChange, defaults to tab and escape. It is highly recommended to include Escape in the array, while Tab may be omitted if the menu contains non-menu items that are focusable. */
Expand All @@ -38,7 +34,7 @@
/** Aria label for search input */
searchInputAriaLabel?: string;
/** Toggle to be rendered */
toggle: DropdownToggleProps | ((toggleRef: React.RefObject<any>) => React.ReactNode);

Check warning on line 37 in packages/module/src/AttachMenu/AttachMenu.tsx

View workflow job for this annotation

GitHub Actions / call-build-lint-test-workflow / lint

Unexpected any. Specify a different type
}

export const AttachMenu: FunctionComponent<AttachMenuProps> = ({
Expand Down
2 changes: 1 addition & 1 deletion packages/module/src/MessageBar/MessageBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ export const MessageBarBase: FunctionComponent<MessageBarProps> = ({
onOpenChangeKeys={attachMenuProps?.onAttachMenuOnOpenChangeKeys}
onSelect={attachMenuProps?.onAttachMenuSelect}
{...(attachMenuProps && { handleTextInputChange: attachMenuProps.onAttachMenuInputChange })}
popperProps={{ direction: 'up', distance: '8' }}
popperProps={{ direction: 'up', distance: 8 }}
searchInputPlaceholder={attachMenuProps?.attachMenuInputPlaceholder}
/>
);
Expand Down
Loading