Skip to content

fix(ResponseActions): Adjust focus background color #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rebeccaalpert merged 2 commits into from
Nov 10, 2025
Merged

fix(ResponseActions): Adjust focus background color #739

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a7ec4e
fix(ResponseActions): Adjust focus background color
rebeccaalpert Oct 28, 2025
2aa51f2
Adjust to use token
rebeccaalpert Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/module/src/ResponseActions/ResponseActions.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
--pf-v6-c-button__icon--Color: var(--pf-t--global--icon--color--subtle);
}
&:focus {
--pf-v6-c-button--hover--BackgroundColor: var(--pf-t--global--background--color--action--plain--alt--clicked);
--pf-v6-c-button__icon--Color: var(--pf-t--global--icon--color--regular);
background-color: var(--pf-v6-c-button--hover--BackgroundColor);
Copy link
Member

@srambach srambach Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work if you set --pf-v6-c-button--BackgroundColor rather than the property itself? (seems to in the inspector but I could be missing some side effect)

Copy link
Member Author

@rebeccaalpert rebeccaalpert Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me? I'll sub it out. Thank you! 🙌

}
}
}
Expand Down
Loading