Skip to content

fix(nav): prevent overflow of nav items causing page body overflow #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmcfaul merged 2 commits into from
Sep 23, 2025
Merged

fix(nav): prevent overflow of nav items causing page body overflow #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f403f4
fix(nav): prevent overflow of nav items causing page body overflow
wise-king-sullyman Sep 16, 2025
0cd6f4e
update snapshot
wise-king-sullyman Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const Navigation: React.FunctionComponent<NavigationProps> = ({

return (
// Can possibly add back PageSidebar wrapper when https://github.com/patternfly/patternfly/issues/7377 goes in
<PageSidebarBody id="page-sidebar-body">
<PageSidebarBody id="page-sidebar-body" style={{ overflowY: 'auto' }}>
<Nav onSelect={onNavSelect}>
<NavList>
{navData.map((navEntries) => {
Expand Down
1 change: 1 addition & 0 deletions src/components/__tests__/__snapshots__/Navigation.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ exports[`matches snapshot 1`] = `
<div
class="pf-v6-c-page__sidebar-body"
id="page-sidebar-body"
style="overflow-y: auto;"
>
<nav
aria-label="Global"
Expand Down