feat(API): add text content API #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wise-king-sullyman
force-pushed
the
text-file-api
branch
from
351905f to
48e0d85
Compare
dlabaj
requested changes
Oct 21, 2025
Contributor
dlabaj
left a comment
dlabaj
left a comment
There was a problem hiding this comment.
A few comments otherwise looks good.
src/pages/text/[version].ts
Outdated
| if (!version) { | ||
| return new Response( | ||
| JSON.stringify({ error: 'Version parameter is required' }), | ||
| { status: 400, headers: { 'Content-Type': 'application/json' } }, |
Contributor
There was a problem hiding this comment.
We should create a helper function to generate the HTTP headers. Content-Type should also specify character encoding. Would set this to application/json; charset=utf-8
| return new Response( | ||
| JSON.stringify({ error: 'Version parameter is required' }), | ||
| { status: 400, headers: { 'Content-Type': 'application/json' } }, | ||
| ) |
Contributor
There was a problem hiding this comment.
For the header we should also include the Content-Length, Date, and disable caching by setting Cache-Control to no-cache. I'm not sure about CORS, it's something we can probably skip right now while in development but may need to revisit later.
src/pages/text/openapi.json.ts
Outdated
| }, | ||
| servers: [ | ||
| { | ||
| url: '/text', |
Contributor
There was a problem hiding this comment.
I would change this to /api
dlabaj
approved these changes
Oct 21, 2025
|
🎉 This PR is included in version 1.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
wise-king-sullyman
added a commit
that referenced
this pull request
Nov 27, 2025
This reverts commit 3798460.
wise-king-sullyman
added a commit
that referenced
this pull request
Nov 27, 2025
Revert "feat(API): add text content API (#174)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #151
Assisted by Claude Code running claude-3-5-haiku and claude-sonnet