feat(Tabs): add logic for component tabs & nav routing #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Looking great! A few various things below, also I'd love if we could figure out the performance issues here, but that could be a followup.
4 tasks
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
[...tab].astroto build a tab dictionary from available routes (stored incomponentTabs) and then sort the tabs in a specified order (from org repo).entry.idandentry.data.idfieldsid) & route to/components/{kebab-component}[...page].astroto rewrite content to[...tab].astrofor component pages (so that /component/alert effectively will show /component/alert/react). It should be picking the first available tab based on thecomponentTabsglobal.Page.astro, removing the wrapping PF Content component (this was interfering with rendering the tabs classes)Todos: