fix(Main): Handle scrolling to anchor links #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccaalpert
requested review from
dlabaj,
kmcfaul,
thatblindgeye and
wise-king-sullyman
rebeccaalpert
commented
May 21, 2025
| const hash = window.location.hash | ||
|
|
||
| // Without this, page would focus on anchor link without scrolling to it | ||
| history.replaceState(null, '', ' ') |
Member
Author
There was a problem hiding this comment.
Totally open to suggestions here if we hate this.
wise-king-sullyman
approved these changes
May 22, 2025
thatblindgeye
approved these changes
May 22, 2025
Collaborator
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
lgtm, had a question below but not really blocking
|
|
||
| .ws-heading { | ||
| position: relative; | ||
| scroll-margin-top: 3rem; |
Collaborator
There was a problem hiding this comment.
I'm not sure if I'm noticing any difference when removing this line, is it necessary for anything in particular?
Member
Author
There was a problem hiding this comment.
It just adds space above the scroll target!
Without:
With:
|
🎉 This PR is included in version 1.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used a timeout here because we have islands and I wasn't sure if we wanted to specifically look for anchor links instead - let me know if that's the preferred solution.
Tested with CSS var links with content.ts commented in.
Fixes #56.