fix(CodeEditor): Prevent loss of styles/JS #69
Conversation
rebeccaalpert
force-pushed
the
codeeditor
branch
2 times, most recently
from
173b6f9 to
e917448
Compare
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Editor wonkyness does seem fixed, but the flash in dark theme still seems pretty rough.
I'm not opposed to us merging this if we make a followup to address the flash further at some point though.
The Monaco code editor injects styles and JavaScript tags into the header. Usually, in React, this is fine. In Astro, with transitions, this breaks down. I tried manually adding these and it broke Monaco. Instead, forcing a reload and trying to fix dark mode seemed like a better way to go.
rebeccaalpert
force-pushed
the
codeeditor
branch
from
e917448 to
88b9f63
Compare
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
I'm fine with this being an interim solution at least, I think the code editor losing styles is more of a blocker than the flash.
I'm still puzzled why it's somehow losing the injected styles when the rendered elements should have the client:load directive (so it should be waiting to render client side anyways). Maybe there's some caching setting we're missing somewhere.
|
Here's that follow-on: #96 |
|
🎉 This PR is included in version 1.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
The Monaco code editor injects styles and JavaScript tags into the header. Usually, in React, this is fine. In Astro, with transitions, this breaks down. I tried manually adding these and it broke Monaco. Instead, forcing a reload and trying to fix dark mode seemed like a better way to go.