feat: Page template updates. #8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,4 +2,4 @@ | |
| import { Toolbar as ReactToolbar } from './Toolbar.tsx' | ||
| --- | ||
|
|
||
| <ReactToolbar client:idle /> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| import React from 'react' | ||
| import { | ||
| Dropdown, | ||
| DropdownList, | ||
| MenuToggle, | ||
| DropdownGroup, | ||
| DropdownItem, | ||
| Divider, | ||
| } from '@patternfly/react-core' | ||
| import { Release } from '../../types' | ||
| import versions from '../../versions.json' | ||
|
|
||
| export const DocumentReleaseDropdown: React.FunctionComponent = () => { | ||
| const latestRelease = versions.Releases.find( | ||
| (release) => release.latest, | ||
| ) as Release | ||
| const previousReleases = Object.values(versions.Releases).filter( | ||
| (release) => !release.hidden && !release.latest, | ||
| ) as Release [] | ||
|
|
||
| const previousVersions = Object.values(versions.ArchivedReleases) as Release[]; | ||
|
Comment on lines
+14
to
+21
Contributor
There was a problem hiding this comment. Nit: is there a way we could avoid all these type casts? |
||
|
|
||
| const [isDropdownOpen, setDropdownOpen] = React.useState(false) | ||
|
|
||
| const getDropdownItem = (version: Release, isLatest = false) => ( | ||
| <DropdownItem | ||
| itemId={`${version.name}-latest-release`} | ||
| key={`${version.name}-latest`} | ||
| // eslint-disable-next-line no-nested-ternary | ||
| to={isLatest ? '/' : version.href ? version.href : `/${version.name}`} | ||
|
Contributor
There was a problem hiding this comment. Nit: I don't love this nested ternary either |
||
| isExternalLink = {version.href ? true : false} | ||
| > | ||
| {`Release ${version.name}`} | ||
| </DropdownItem> | ||
| ) | ||
| return ( | ||
| <Dropdown | ||
| onSelect={() => setDropdownOpen(!isDropdownOpen)} | ||
| onOpenChange={(isOpen) => setDropdownOpen(isOpen)} | ||
| isOpen={isDropdownOpen} | ||
| toggle={(toggleRef) => ( | ||
| <MenuToggle | ||
| ref={toggleRef} | ||
| onClick={() => setDropdownOpen(!isDropdownOpen)} | ||
| isExpanded={isDropdownOpen} | ||
| > | ||
| {`Release ${latestRelease.name}`} | ||
| </MenuToggle> | ||
| )} | ||
| popperProps={{ position: 'right' }} | ||
| > | ||
| <DropdownGroup key="Latest" label="Latest"> | ||
| <DropdownList>{getDropdownItem(latestRelease, true)}</DropdownList> | ||
| </DropdownGroup> | ||
| {previousReleases.length > 0 && ( | ||
| <DropdownGroup key="Previous releases" label="Previous releases"> | ||
| <DropdownList> | ||
| {previousReleases | ||
| .slice(0, 3) | ||
|
Contributor
There was a problem hiding this comment. Nit: is this slice just a magic number sort of thing where we're grabbing the last three versions just because 3, 4 and 5 are the only previous versions we care about? If so I don't love that. |
||
| .map((version) => getDropdownItem(version))} | ||
| </DropdownList> | ||
| </DropdownGroup> | ||
| )} | ||
| {previousVersions.length > 0 && ( | ||
| <><Divider key="divider1" /><DropdownGroup key="Previous versions" label="Previous versions"> | ||
|
Contributor
There was a problem hiding this comment. Nit: the formatting is kind of funky here, seems like prettier just needs to be ran. |
||
| <DropdownList> | ||
| {previousVersions.map((version) => getDropdownItem(version))} | ||
| </DropdownList> | ||
| </DropdownGroup></>)} | ||
| </Dropdown> | ||
| ) | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious on the "why" behind this eslint config change