Skip to content

Commit 117a0e7

Browse files
castastrophegithub-actions[bot]starryeyez024
authored
feat: Rename theme to context (#996)
* feat: Straight find-replace on --theme * feat: tackle other theme references * feat: Update pfelement theme references * feat: Working through compilation errors * Update pfe-band_test.html Bring back pfe-band mark-up on test page * feat: Update changelog * feat: Updating references and documentation * feat: Updating documentation and references to the old theme value * feat: Updates to the writing styles documentation * feat: Updating demo pages to support web components * feat: Update slot styling documentation * feat: Updating documentation * feat: Finish up the theme intro documentation updates * feat: Tweaking the theming and palette docs * Apply suggestions from code review Co-authored-by: Kendall Totten <[email protected]> * feat: Remove specificity of not selector Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kendall Totten <[email protected]>
1 parent 40e0b09 commit 117a0e7

File tree

47 files changed

+8712
-731
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+8712
-731
lines changed

.gitattributes

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,3 @@ elements/*/*.js.map -diff -merge
55
elements/*/gulpfile.js diff merge
66
elements/*/rollup.config.js diff merge
77
elements/*/*.story.js diff merge
8-
9-
themes/*/*.js -diff -merge
10-
themes/*/*.js.map -diff -merge
11-
themes/*/gulpfile.js diff merge
12-
themes/*/rollup.config.js diff merge

.github/ISSUE_TEMPLATE/new_component.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ labels: "design system, new component request, priority: low"
1212
## Design specification
1313

1414
<!--
15-
Snapshots and link to mock-ups for this component. Should cover themes and states with guidelines for spacing, typography, and structure. Breakpoint details for desktop, tablet, and mobile or general guidance for responsive changes.
15+
Snapshots and link to mock-ups for this component. Should cover contexts and states with guidelines for spacing, typography, and structure. Breakpoint details for desktop, tablet, and mobile or general guidance for responsive changes.
1616
-->
1717

1818

.github/ISSUE_TEMPLATE/update_component.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ labels: "design system, update component request, priority: low"
1212
## Design specification updates
1313

1414
<!--
15-
Snapshots and link to mock-ups for this component update. Should cover themes and states with guidelines for spacing, typography, and structure. Breakpoint details for desktop, tablet, and mobile or general guidance for responsive changes.
15+
Snapshots and link to mock-ups for this component update. Should cover contexts and states with guidelines for spacing, typography, and structure. Breakpoint details for desktop, tablet, and mobile or general guidance for responsive changes.
1616
-->
1717

1818

CHANGELOG-1.x.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,5 @@
1212
- [47a1f4f](https://github.com/patternfly/patternfly-elements/commit/47a1f4fe9365f9366974fe67a30b48cc91e4e6a8) fix: unwanted padding on pfe-accordion (#1083)
1313
- [e3cc73b](https://github.com/patternfly/patternfly-elements/commit/e3cc73b92d06cdf7fef8dc091733a046a14e12e5) fix: pfe-tabs vertical display on mobile (#1135)
1414
- [6eadb21](https://github.com/patternfly/patternfly-elements/commit/6eadb21a29768c06ff312de42bd54b44072ee051) fix: umd.min modules now import umd.min builds of PFE dependencies (#1168)
15-
- [](https://github.com/patternfly/patternfly-elements/commit/) fix: global theme palette color for visited links in a saturated context
15+
- [40e0b09](https://github.com/patternfly/patternfly-elements/commit/40e0b099e77943feee4e8ba1a34d25b01ddf86ff) fix: global theme palette color for visited links in a saturated context
16+
- [](https://github.com/patternfly/patternfly-elements/commit/) fix: Variable references to theme vs. context

README.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,6 @@ Many commands have an optional argument of space-separated component name(s), if
4747
# Build and watch all components, run the server to preview demo pages
4848
npm run dev
4949

50-
51-
52-
# Run, watch, and build one or more component(s)
53-
=======
5450
# Build and watch on one or more components, run the server to preview demo pages
5551
npm run dev [component-name(s)]
5652
```
@@ -63,6 +59,9 @@ npm start
6359

6460
# Runs storybook preview tool
6561
npm run storybook
62+
63+
# Open documentation
64+
npm run docs
6665
```
6766

6867
### Compile & Preview
@@ -79,7 +78,7 @@ npm run live-demo [component-name(s)]
7978

8079
```shell
8180
# Build and run tests on all components
82-
npm run test
81+
npm run test
8382

8483
# Build and run tests on one component
8584
npm run test [component-name(s)]
@@ -89,7 +88,7 @@ npm run test [component-name(s)]
8988

9089
```shell
9190
# Open a new pull request
92-
npm run pr
91+
npm run pr
9392
```
9493

9594
## Support

docs/assets/pfe-base-sass/functions/_functions.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@
3737
@return $collection;
3838
}
3939

40-
// New color function to only return theme colors
41-
@function color( $name, $theme: "light", $opacity: 1 ) {
40+
// New color function to only return context colors
41+
@function color( $name, $context: "light", $opacity: 1 ) {
4242
$map: map-get($color-map, $name);
4343
$error: false;
4444
$color: null;
4545
@if $map != null {
46-
$color: map-get($map, $theme);
46+
$color: map-get($map, $context);
4747
}
4848
@else {
4949
$error: true;

0 commit comments

Comments
 (0)