Skip to content

Commit 53f693f

Browse files
authored
CI: Clean up issues still in the scripts
1 parent 07d1466 commit 53f693f

File tree

3 files changed

+19
-8
lines changed

3 files changed

+19
-8
lines changed

.github/workflows/automerge.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
name: Auto-merge pull request if requirements met
44

55
on:
6+
pull_request_review:
7+
types:
8+
- submitted
69
workflow_run:
710
workflows: ["Build & test"]
811
types:
@@ -14,8 +17,7 @@ jobs:
1417
runs-on: ubuntu-latest
1518
steps:
1619
- name: Attempt merge
17-
if: github.event.workflow_run.conclusion == 'success'
18-
uses: "pascalgn/[email protected]"
20+
uses: pascalgn/[email protected]
1921
env:
2022
GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
2123
MERGE_LABELS: "!work in progress!,!on hold,!blocked,!needs: code updates,!needs: additional info,!needs: AT updates,!needs: changelog,!ready: branch testing,!ready: browser testing"
@@ -24,4 +26,4 @@ jobs:
2426
MERGE_COMMIT_MESSAGE: "pull-request-title"
2527
MERGE_RETRIES: 3
2628
MERGE_RETRY_SLEEP: 10000
27-
UPDATE_METHOD: rebase
29+
UPDATE_METHOD: merge

.github/workflows/label.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@ name: Auto-label PRs
66

77
on:
88
pull_request:
9-
types: [opened, convert_to_draft, ready_for_review]
9+
types:
10+
- opened
11+
- convert_to_draft
12+
- ready_for_review
1013
pull_request_review:
1114
types: [submitted]
1215

.github/workflows/tests.yml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,13 @@
44
name: Build & test
55

66
on:
7-
# Manual run, no inputs necessary
8-
workflow_dispatch: []
97
# Build when a PR
108
pull_request:
11-
types: [opened, synchronize, labeled, ready_for_review]
9+
types:
10+
- opened
11+
- synchronize
12+
- labeled
13+
- ready_for_review
1214
# Will only run if files other than these are edited
1315
paths-ignore:
1416
- ".github/ISSUE_TEMPLATE/**"
@@ -22,13 +24,16 @@ on:
2224
# Build when PRs are merged into master/main
2325
push:
2426
branches: [master, main]
27+
# Manual run, no inputs necessary
28+
workflow_dispatch:
2529

2630
env:
2731
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2832

2933
# For webdriver script
3034
BROWSERSTACK_USER: ${{ secrets.BROWSERSTACK_USER }}
3135
BROWSERSTACK_KEY: ${{ secrets.BROWSERSTACK_KEY }}
36+
3237
# https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
3338
ACTIONS_ALLOW_UNSECURE_COMMANDS: "true"
3439

@@ -156,7 +161,8 @@ jobs:
156161
if: |
157162
contains(github.event.pull_request.labels.*.name, 'ready to merge') ||
158163
contains(github.event.pull_request.labels.*.name, 'run e2e') ||
159-
contains(github.event.pull_request.user.login, 'dependabot')
164+
contains(github.event.pull_request.user.login, 'dependabot') ||
165+
contains(github.event.pull_request.user.login, 'dependabot-preview')
160166
runs-on: ubuntu-latest
161167
strategy:
162168
matrix:

0 commit comments

Comments
 (0)