Skip to content

Commit a02d6e5

Browse files
heyMP[ Cassondra ]github-actions[bot]castastrophe
authored
Fix issue 1175 cta ie (#1194)
* chore: check-in * added an ie11 query to set a tag to use pfe-color color * fix: Update baselines * fixed the cta's from appearing thicker on ie11 * fix: Update baselines * chore: update changelog * Update CHANGELOG-1.x.md Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]>
1 parent 117a0e7 commit a02d6e5

File tree

12 files changed

+16
-25
lines changed

12 files changed

+16
-25
lines changed

CHANGELOG-1.x.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,5 @@
1313
- [e3cc73b](https://github.com/patternfly/patternfly-elements/commit/e3cc73b92d06cdf7fef8dc091733a046a14e12e5) fix: pfe-tabs vertical display on mobile (#1135)
1414
- [6eadb21](https://github.com/patternfly/patternfly-elements/commit/6eadb21a29768c06ff312de42bd54b44072ee051) fix: umd.min modules now import umd.min builds of PFE dependencies (#1168)
1515
- [40e0b09](https://github.com/patternfly/patternfly-elements/commit/40e0b099e77943feee4e8ba1a34d25b01ddf86ff) fix: global theme palette color for visited links in a saturated context
16-
- [](https://github.com/patternfly/patternfly-elements/commit/) fix: Variable references to theme vs. context
16+
- [117a0e7](https://github.com/patternfly/patternfly-elements/commit/117a0e7e407ea1244cc861b251391f61a8b143ef) fix: Variable references to theme vs. context
17+
- [7c7093a1](https://github.com/patternfly/patternfly-elements/commit/7c7093a1b4d099941320558e54003a0beca01eda) fix: ie11 pfe-cta link text and padding issues

elements/pfe-cta/src/pfe-cta--lightdom.scss

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,6 @@ pfe-cta {
1818
}
1919

2020
@include browser-query(ie11 edge) {
21-
pfe-cta[priority] a,
22-
pfe-cta[priority] a,
23-
pfe-cta[aria-disabled="true"] a {
24-
padding: #{pfe-local(
25-
$cssvar: Padding,
26-
$fallback: #{pfe-var(container-padding)} calc(#{pfe-var(
27-
container-padding
28-
)} * 2)
29-
)} !important;
30-
}
31-
3221
// Edge 17 & 18 arrow wrap
3322
.pfe-cta--wrapper {
3423
white-space: nowrap;

elements/pfe-cta/src/pfe-cta.scss

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -79,18 +79,28 @@ $LOCAL-VARIABLES: map-deep-merge($LOCAL-VARIABLES, (
7979

8080
// cursor: pointer;
8181

82-
@include browser-query(ie11 edge) {
83-
padding: 0 !important;
84-
}
85-
8682
:host([priority]) & {
8783
text-align: center;
8884
font-size: pfe-local(FontSize--priority);
85+
@include browser-query(ie11) {
86+
a {
87+
color: pfe-local(Color) !important;
88+
}
89+
}
8990
}
9091

9192
:host([aria-disabled="true"]) & {
9293
cursor: default !important;
9394
}
95+
96+
:host([priority]) &,
97+
:host([aria-disabled="true"]) & {
98+
padding: pfe-local(Padding, $fallback: pfe-var(container-padding) calc(#{pfe-var(container-padding)} * 2)) !important;
99+
100+
@include browser-query(ie11) {
101+
padding: pfe-fetch(container-padding) #{pfe-fetch(container-padding) * 2} !important;
102+
}
103+
}
94104
}
95105

96106
:host(:not([aria-disabled="true"]):focus),
@@ -167,15 +177,6 @@ $LOCAL-VARIABLES: map-deep-merge($LOCAL-VARIABLES, (
167177
display: none;
168178
}
169179

170-
:host([priority]),
171-
:host([aria-disabled="true"]) {
172-
--pfe-cta--Padding: #{pfe-var(container-padding)} calc(#{pfe-var(container-padding)} * 2);
173-
::slotted(*) {
174-
@include browser-query(ie11) {
175-
padding: pfe-fetch(container-padding) #{pfe-fetch(container-padding) * 2};
176-
}
177-
}
178-
}
179180

180181
/// ===========================================================================
181182
/// BELOW THIS POINT, LOCAL VARIABLE OVERRIDES ONLY, handled by the pfe-print-local function
-461 Bytes
Loading
-1.18 KB
Loading
19.5 KB
Loading
1.33 KB
Loading
104 Bytes
Loading
756 Bytes
Loading
554 Bytes
Loading

0 commit comments

Comments
 (0)