Skip to content

fix(tools): fix type errors in create-element template #2873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bennypowers merged 3 commits into from
Nov 10, 2024
Merged

fix(tools): fix type errors in create-element template #2873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b27da42
fix(tools): fix type errors in create-element template
martinpitt Nov 8, 2024
63e3e9e
docs: create dull-stingrays-film.md
bennypowers Nov 10, 2024
7f8abd9
chore: update package.json
bennypowers Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dull-stingrays-film.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@patternfly/create-element": patch
---

Fixed type errors in create-element template
3 changes: 3 additions & 0 deletions tools/create-element/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
"bin": {
"create-app": "bin/main.js"
},
"contributors": [
"Martin Pitt <[email protected]>"
],
"keywords": [
"custom elements",
"custom-elements",
Expand Down
6 changes: 3 additions & 3 deletions tools/create-element/templates/element/element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { LitElement, html } from 'lit';
import { LitElement, html, type TemplateResult } from 'lit';
import { customElement } from 'lit/decorators/custom-element.js';

import styles from '<%= cssRelativePath %>';
Expand All @@ -9,9 +9,9 @@ import styles from '<%= cssRelativePath %>';
*/
@customElement('<%= tagName %>')
export class <%= className %> extends LitElement {
static readonly styles = [styles];
static readonly styles: CSSStyleSheet[] = [styles];

render() {
render(): TemplateResult<1> {
return html`
<slot></slot>
`;
Expand Down
Loading