Skip to content

Conversation

@jonkoops
Copy link
Contributor

Upgrades Yarn to a version that is not end-of-life. This is just to make my life easier as I can't get the old Yarn to work on my system for some reason.

@jonkoops
Copy link
Contributor Author

FYI the CI failures are nonsense. Snyk is failing as it detected the migrations from Yarn as changes to the dependencies, but they have not changed. And the build-upload check is failing as the job is triggered from main which does not have the required changes to run the new Yarn (as they are in this PR). I have tested this locally, and the build passes just fine.

Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabaj
Copy link
Contributor

dlabaj commented Nov 21, 2024

Note that pr-preview and snyk preview are failing because of what is on main. Not this PR.

@jonkoops
Copy link
Contributor Author

Looks like the PR has conflicted due to some changes to the main branch, I will see if I can do a rebase.

@nicolethoen nicolethoen merged commit 4a41684 into patternfly:main Nov 21, 2024
1 check failed
@jonkoops jonkoops deleted the upgrade-yarn branch November 21, 2024 18:07
jonkoops added a commit to jonkoops/patternfly-org that referenced this pull request Nov 21, 2024
nicolethoen pushed a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants