fix: improve handling of dark mode preferences #4389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkoops
force-pushed
the
dark-mode-improvements
branch
from
5e6a088 to
b252f95
Compare
Collaborator
Closes patternfly#4365 Signed-off-by: Jon Koops <[email protected]>
jonkoops
force-pushed
the
dark-mode-improvements
branch
from
b252f95 to
b6ea0d4
Compare
dlabaj
approved these changes
Nov 22, 2024
This was referenced Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the handling of dark mode preferences by respecting the system/browser preference of the user first, and storing the preference in local storage when the user toggles the switch manually in the user interface. This allows the preference to be persisted between other tabs and windows.
Closes #4365