Skip to content

fix(styling): Allow for spacing between paragraphs of non-stack text #4397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(styling): Allow for spacing between paragraphs of non-stack text #4397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d9a477
fix(styling): Allow for spacing between paragraphs of non-stack text
wise-king-sullyman Dec 2, 2024
4e44bdf
chore(docs): updatin spacin
mcoker Dec 16, 2024
0250b2d
Merge branch 'main' into fix-paragraph-spacing
wise-king-sullyman Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/documentation-framework/components/autoLinkHeader/autoLinkHeader.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@

.ws-heading-anchor {
color: var(--pf-t--global--icon--color--regular);
transform: translate(calc(-100% - var(--pf-t--global--spacer--xs)), -50%);
transform: translate(-100%, -50%);
opacity: 0;
position: absolute;
left: 0;
top: 50%;
padding-inline-end: var(--pf-t--global--spacer--xs);
}

.ws-heading-anchor-icon {
Expand Down
26 changes: 13 additions & 13 deletions packages/documentation-framework/components/autoLinkHeader/autoLinkHeader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,22 @@ export const AutoLinkHeader = ({
const slug = id || slugger(children);

return (
<Flex alignItems={{ default: 'alignItemsCenter'}} spaceItems={{ default: "spaceItemsSm" }}>
<Content
id={slug}
component={headingLevel}
className={css('ws-heading', className)}
tabIndex={-1}
isEditorial
>
<Flex alignItems={{ default: 'alignItemsCenter'}} spaceItems={{ default: "spaceItemsSm" }} className={`ws-autolink-header ws-autolink-header-${headingLevel}`}>
<FlexItem>
<Content
id={slug}
component={headingLevel}
className={css('ws-heading', className)}
tabIndex={-1}
isEditorial
>
<Link href={`#${slug}`} className="ws-heading-anchor" tabIndex="-1" aria-hidden>
<LinkIcon className="ws-heading-anchor-icon" style={{ verticalAlign: 'middle' }} />
</Link>
{children}
</Content>
<Link href={`#${slug}`} className="ws-heading-anchor" tabIndex="-1" aria-hidden>
<LinkIcon className="ws-heading-anchor-icon" style={{ verticalAlign: 'middle' }} />
</Link>
{children}
</FlexItem>
{metaText && <FlexItem>{metaText}</FlexItem>}
</Flex>
</Content>
)
};
9 changes: 7 additions & 2 deletions packages/documentation-framework/components/example/example.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
--ws-code-editor--tooltip--MaxWidth: 16ch;
}

.ws-code-editor:not(.ws-example-code-expanded) > .pf-v6-c-code-editor__header::before {
--pf-v6-c-code-editor__header--before--BorderBottomWidth: 0;
.ws-code-editor {
--pf-v6-c-code-editor__header-content--PaddingInlineStart: 0;
--pf-v6-c-code-editor__header-content--PaddingInlineEnd: 0;
}

.ws-code-editor-control {
Expand Down Expand Up @@ -86,3 +87,7 @@
opacity: 0.8;
box-shadow: var(--pf-t--global--box-shadow--sm);
}

.ws-example-toolbar {
margin-block-end: var(--pf-t--global--spacer--lg);
}
4 changes: 2 additions & 2 deletions packages/documentation-framework/components/example/example.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ export const Example = ({
</AutoLinkHeader>
{children}
</StackItem>
<StackItem>
<StackItem className="ws-example-preview">
{isFullscreen ? (
<div>
<a
Expand Down Expand Up @@ -323,7 +323,7 @@ export const Example = ({
</div>
)}
</StackItem>
<StackItem>
<StackItem className="ws-example-toolbar">
<ExampleToolbar
lang={lang}
isFullscreen={isFullscreen}
Expand Down
12 changes: 10 additions & 2 deletions packages/documentation-framework/templates/mdx.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
p.pf-v6-c-content--p.ws-p {
margin: 0;
.ws-content.pf-v6-l-stack > [class*="pf-v6-c-content"] {
margin-bottom: 0;
}

.ws-content {
max-width: 825px;
}

.ws-code {
Expand All @@ -24,6 +28,10 @@ p.pf-v6-c-content--p.ws-p {
z-index: var(--pf-t--global--z-index--2xl);
}

.ws-autolink-header:not(:first-child) {
margin-top: var(--pf-t--global--spacer--md);
}

.ws-example-page-wrapper {
max-width: min(100%, 825px);
}
2 changes: 0 additions & 2 deletions ...ternfly-docs/content/design-guidelines/usage-and-behavior/usage-and-behavior.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ id: Usage and behavior
section: design-foundations
---

# PatternFly component usage and behavior guidelines

As you design with PatternFly, you might encounter common use cases where multiple components could be used. These guidelines outline which component to use in these situations and shares where to find more detailed usage guidelines.

## Displaying structured data
Expand Down