fix(dark-theme): fixed issue with incorrect color-scheme being applied #4408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nicolethoen
approved these changes
Dec 9, 2024
dlabaj
approved these changes
Dec 9, 2024
kmcfaul
approved these changes
Dec 10, 2024
jonkoops
reviewed
Dec 11, 2024
| <head> | ||
| <meta charset="utf-8"> | ||
| <meta name="viewport" content="width=device-width,initial-scale=1,shrink-to-fit=no"> | ||
| <meta name="color-scheme" content="light dark"> |
Contributor
There was a problem hiding this comment.
This metadata indicates that dark mode as well as light mode is supported, why remove it?
Contributor
There was a problem hiding this comment.
This was creating an issue where the system preference was dictating the color of checkboxes and radio buttons, superseding the actual selected theme.
Contributor
There was a problem hiding this comment.
Talked to @mcoker about it and reverting this is fine, we'll have to get back to a proper fix at a later time 👍
dlabaj
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4404