fix(CalendarMonth): fix selection closing datepicker popover #11341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-11341.surge.sh A11y report: https://patternfly-react-pr-11341-a11y.surge.sh |
tlabaj
requested review from
a team,
tlabaj and
wise-king-sullyman
and removed request for
a team
thatblindgeye
approved these changes
Dec 10, 2024
tlabaj
approved these changes
Dec 10, 2024
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
mattnolting
pushed a commit
to mattnolting/patternfly-react
that referenced
this pull request
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #11329
CalendarMonth's select was closing the Datepicker popover because the Select wasn't inline/was appended to the body (so the Datepicker saw the click as coming from outside the picker).
The timeout in the selection handler doesn't seem to be necessary in v6.