Skip to content

Refactor(DataList): removed aria-labelledby and aria-selected #11569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thatblindgeye merged 3 commits into from
Mar 4, 2025
Merged

Refactor(DataList): removed aria-labelledby and aria-selected #11569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7825c9
Refactor(DataList): removed aria-labelledby and aria-selected
Mash707 Feb 26, 2025
b0d9617
updated snapshot for DataListItem
Mash707 Feb 27, 2025
af53cbe
updated prop description
Mash707 Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/react-core/src/components/DataList/DataListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export interface DataListItemProps extends Omit<React.HTMLProps<HTMLLIElement>,
children: React.ReactNode;
/** Additional classes added to the DataList item should be either <DataListItemRow> or <DataListContent> */
className?: string;
/** Adds accessible text to the DataList item */
/** Adds an accessible name to the selectable input if one is rendered */
'aria-labelledby': string;
/** Unique id for the DataList item */
id?: string;
Expand Down Expand Up @@ -86,9 +86,7 @@ class DataListItem extends React.Component<DataListItemProps> {
selectedDataListItemId && isSelected && styles.modifiers.selected,
className
)}
aria-labelledby={ariaLabelledBy}
{...(isSelectable && { tabIndex: 0, onClick: selectDataListItem, onKeyDown })}
{...(isSelectable && isSelected && { 'aria-selected': true })}
{...props}
>
{onSelectableRowChange && (
Expand Down
1 change: 0 additions & 1 deletion ...core/src/components/DataList/__tests__/Generated/__snapshots__/DataListItem.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
exports[`DataListItem should match snapshot (auto-generated) 1`] = `
<DocumentFragment>
<li
aria-labelledby="string"
class="pf-v6-c-data-list__item ''"
id="''"
>
Expand Down
1 change: 0 additions & 1 deletion ...ges/react-core/src/components/DataList/__tests__/__snapshots__/DataListItem.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
exports[`Renders to match snapshot 1`] = `
<DocumentFragment>
<li
aria-labelledby="item-1"
class="pf-v6-c-data-list__item"
id=""
/>
Expand Down
Loading