Chore(ChartLegend): updated interactive legend example #11623
Conversation
|
Preview: https://patternfly-react-pr-11623.surge.sh A11y report: https://patternfly-react-pr-11623-a11y.surge.sh |
|
@thatblindgeye we have more examples in legends tab that need to be updated. |
|
@rebeccaalpert wdyt re: the above comment? The issue only called out a specific example, but was the intent that other examples would also be updated? |
|
I think ideally, I'd love to see all our examples in current syntax over time, but I'm personally a fan of small PRs. I think it might be better if we had separate issues for the others. The fact that it was in class syntax was a real hurdle for the guy I'm working with (new to React; didn't live through class syntax). |
|
For now let's keep this PR to updating the specified example from the linked issue. We can look into opening a followup down the line if it comes up again. |
rebeccaalpert
left a comment
rebeccaalpert
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for updating!
| getInteractiveLegendEvents, | ||
| getInteractiveLegendItemStyles, | ||
| } from '@patternfly/react-charts/victory'; | ||
| } from '@patternfly/react-charts'; |
There was a problem hiding this comment.
Can we keep the original import path?
There was a problem hiding this comment.
Sure, we can keep it. I might have changed it accidentally.
Mash707
force-pushed
the
update-interactive-legend-example
branch
from
f8dc1fb to
7335c3b
Compare
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
4 participants
Closes #11572