-
Notifications
You must be signed in to change notification settings - Fork 375
feat(react-icons): add rhds icons #12143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
634ce87 to
26b3489
Compare
|
Preview: https://pf-react-pr-12143.surge.sh A11y report: https://pf-react-pr-12143-a11y.surge.sh |
2cad9a8 to
89fe4e3
Compare
89fe4e3 to
c1b9595
Compare
03c6613 to
5a8e92d
Compare
|
@kmcfaul @nicolethoen do you know why the build is failing? I tried clearing the gh action cache. It all works locally - the react repo builds and running |
|
I'll take a look at it in a bit - for our reference, this is the error i'm seeing in the logs: |
4f1e75c to
5952764
Compare
andrew-ronaldson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Future us will want to add a filter and/or search to this page.
fixes #12144
You can see them on https://pf-react-pr-12143.surge.sh/icons by looking for "rhds"
@rhds/iconspackage<path d="{this}">) out of the rhds icons and adds them in JSON toscripts/icons/rhdsIcons[type].mjsfor each of the icon types. The key for each icon is in the format of "rhds-[type]-[icon name]".prettierignoreand added these files to it. I dunno if there's a better/different way to handle that?Right now you need to run
node scripts/parseRHDSIcons.mjsto generate new icons if there is a new version of@rhds/icons. Is that preferred or would we want it to run automatically somehow?Assisted-by: Compass