Skip to content

fix(formFiledGroupHeaderTitleTextObject): use renameInterface helper #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wise-king-sullyman merged 1 commit into from
Feb 4, 2025
Merged

fix(formFiledGroupHeaderTitleTextObject): use renameInterface helper #820

wise-king-sullyman merged 1 commit into from
Feb 4, 2025

Conversation

@adamviktora
Copy link
Contributor

@adamviktora adamviktora commented Jan 31, 2025

Closes #622

  • refactors and fixes the renameInterface helper to support custom messages and check ExportSpecifier too
  • modifies FormFiledGroupHeaderTitleTextObject rule to use the helper (which uses the correct TS node types, unlike the rule before)

wise-king-sullyman
wise-king-sullyman approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@wise-king-sullyman wise-king-sullyman merged commit 4d17ec9 into patternfly:main Feb 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typescript node types - find suitable interfaces

3 participants

@adamviktora @wise-king-sullyman @thatblindgeye