fixes to hasAnimations codemod #845
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,152 +1,128 @@ | ||
| const ruleTester = require("../../ruletester"); | ||
| import * as rule from "./enable-animations"; | ||
|
|
||
| const valid = [ | ||
| // Components not in target list should be ignored | ||
| "<AlertGroup />", | ||
| "import { AlertGroup } from '@patternfly/react-core'; <AlertGroup hasAnimations />", | ||
| "import { AlertGroup } from '@patternfly/react-core'; <AlertGroup hasAnimations={true} />", | ||
| "import { Table } from '@patternfly/react-table'; <Table hasAnimations />", | ||
| // Component not in target components | ||
| "import { Button } from '@patternfly/react-core'; <Button />", | ||
| // DualListSelector without isTree should not get hasAnimations | ||
| "import { DualListSelector } from '@patternfly/react-core'; <DualListSelector />", | ||
| // DualListSelector with isTree={false} should not get hasAnimations | ||
| "import { DualListSelector } from '@patternfly/react-core'; <DualListSelector isTree={false} />", | ||
| // DualListSelector with isTree and hasAnimations already present | ||
| "import { DualListSelector } from '@patternfly/react-core'; <DualListSelector isTree hasAnimations />", | ||
| ]; | ||
|
|
||
| const invalid = [ | ||
| { | ||
| code: "import { AlertGroup } from '@patternfly/react-core'; <AlertGroup />", | ||
| output: "import { AlertGroup } from '@patternfly/react-core'; <AlertGroup hasAnimations />", | ||
| errors: [ | ||
| { | ||
| message: "Consider adding hasAnimations prop to enable component animations.", | ||
| type: "JSXOpeningElement" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| code: "import { DualListSelector } from '@patternfly/react-core'; <DualListSelector isTree />", | ||
| output: "import { DualListSelector } from '@patternfly/react-core'; <DualListSelector isTree hasAnimations />", | ||
| errors: [ | ||
| { | ||
| message: "Consider adding hasAnimations prop to enable component animations.", | ||
| type: "JSXOpeningElement" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| code: "import { DualListSelector } from '@patternfly/react-core'; <DualListSelector isTree={true} />", | ||
| output: "import { DualListSelector } from '@patternfly/react-core'; <DualListSelector isTree={true} hasAnimations />", | ||
| errors: [ | ||
| { | ||
| message: "Consider adding hasAnimations prop to enable component animations.", | ||
| type: "JSXOpeningElement" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| code: "import { TreeView } from '@patternfly/react-core'; <TreeView />", | ||
| output: "import { TreeView } from '@patternfly/react-core'; <TreeView hasAnimations />", | ||
| errors: [ | ||
| { | ||
| message: "Consider adding hasAnimations prop to enable component animations.", | ||
| type: "JSXOpeningElement" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| code: "import { SearchInputExpandable } from '@patternfly/react-core'; <SearchInputExpandable />", | ||
| output: "import { SearchInputExpandable } from '@patternfly/react-core'; <SearchInputExpandable hasAnimations />", | ||
| errors: [ | ||
| { | ||
| message: "Consider adding hasAnimations prop to enable component animations.", | ||
| type: "JSXOpeningElement" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| code: "import { FormFieldGroupExpandable } from '@patternfly/react-core'; <FormFieldGroupExpandable />", | ||
| output: "import { FormFieldGroupExpandable } from '@patternfly/react-core'; <FormFieldGroupExpandable hasAnimations />", | ||
| errors: [ | ||
| { | ||
| message: "Consider adding hasAnimations prop to enable component animations.", | ||
| type: "JSXOpeningElement" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| code: "import { Table } from '@patternfly/react-table'; <Table />", | ||
| output: "import { Table } from '@patternfly/react-table'; <Table hasAnimations />", | ||
| errors: [ | ||
| { | ||
| message: "Consider adding hasAnimations prop to enable component animations.", | ||
| type: "JSXOpeningElement" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| code: `import { AlertGroup, TreeView } from '@patternfly/react-core'; | ||
| <> | ||
| <AlertGroup /> | ||
| <TreeView /> | ||
| </>`, | ||
| output: `import { AlertGroup, TreeView } from '@patternfly/react-core'; | ||
| <> | ||
| <AlertGroup hasAnimations /> | ||
| <TreeView hasAnimations /> | ||
| </>`, | ||
| errors: [ | ||
| { | ||
| message: "Consider adding hasAnimations prop to enable component animations.", | ||
| type: "JSXOpeningElement" | ||
| }, | ||
| { | ||
| message: "Consider adding hasAnimations prop to enable component animations.", | ||
| type: "JSXOpeningElement" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| code: "import { AlertGroup } from '@patternfly/react-core'; <AlertGroup isLiveRegion />", | ||
| output: "import { AlertGroup } from '@patternfly/react-core'; <AlertGroup isLiveRegion hasAnimations />", | ||
| errors: [ | ||
| { | ||
| message: "Consider adding hasAnimations prop to enable component animations.", | ||
| type: "JSXOpeningElement" | ||
| } | ||
| ] | ||
| } | ||
| ]; | ||
|
|
||
| ruleTester.run("enable-animations", rule, { | ||
| valid: valid, | ||
| invalid: invalid, | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick question on this syntax - is this expected? Or would this need to be updated to include examples of the components updated in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is, I've got a script that compiles all of these separate readme's together for the "real" readme and inserts the associated tsx files into these spots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool - thank you for the context here @wise-king-sullyman