fix: split table hasAnimations fix with cli option#848
Merged
wise-king-sullyman merged 4 commits intopatternfly:mainfrom Jul 18, 2025
Merged
fix: split table hasAnimations fix with cli option#848wise-king-sullyman merged 4 commits intopatternfly:mainfrom
wise-king-sullyman merged 4 commits intopatternfly:mainfrom
Conversation
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
Collaborator
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
i thought about adding "If an issue happens, it's Eric's fault", but didn't.
Now see, if you managed to hide some logic where when a user runs the whole command in one call and types a specific phrase to output this, I'd be tempted to let it go in
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
thatblindgeye
approved these changes
Jul 18, 2025
wise-king-sullyman
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if a user passes the option to only run enable-animations, it will skip the version check and ask them "This will update several React Core components. Would you like to include Table? (Note: Some users have reported issues with enabling animations on Table.)"
i thought about adding "If an issue happens, it's Eric's fault", but didn't.
with choices:
"Just React Core components"
or
"React Core and Table components"