Skip to content

feat(ver): update to rc versions #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2024
Merged

feat(ver): update to rc versions #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9215f4
feat(ver): update to rc versions
kmcfaul Oct 3, 2024
d2c0b62
updates to fix tests, update DataListCheck
kmcfaul Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@
"whatwg-fetch": "^3.6.20"
},
"dependencies": {
"@patternfly/react-tokens": "^6.0.0-alpha.35",
"@patternfly/react-tokens": "^6.0.0-prerelease.7",
"sharp": "^0.33.4"
}
},
"packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
}
10 changes: 5 additions & 5 deletions packages/module/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@
"tag": "alpha"
},
"dependencies": {
"@patternfly/react-core": "^6.0.0-alpha.101",
"@patternfly/react-icons": "^6.0.0-alpha.36",
"@patternfly/react-table": "^6.0.0-alpha.102",
"@patternfly/react-core": "^6.0.0-prerelease.21",
"@patternfly/react-icons": "^6.0.0-prerelease.7",
"@patternfly/react-table": "^6.0.0-prerelease.22",
"react-jss": "^10.10.0",
"clsx": "^2.1.1"
},
Expand All @@ -43,8 +43,8 @@
},
"devDependencies": {
"@patternfly/patternfly-a11y": "^4.3.1",
"@patternfly/documentation-framework": "^6.0.0-alpha.83",
"@patternfly/patternfly": "6.0.0-alpha.210",
"@patternfly/documentation-framework": "^6.0.0-alpha.108",
"@patternfly/patternfly": "6.0.0-prerelease.15",
"@types/react": "^18.2.33",
"@types/react-dom": "^18.2.14",
"react": "^18.3.1",
Expand Down
46 changes: 22 additions & 24 deletions packages/module/src/BulkSelect/BulkSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const BulkSelectValue = {
nonePage: 'nonePage'
} as const;

export type BulkSelectValue = typeof BulkSelectValue[keyof typeof BulkSelectValue];
export type BulkSelectValue = (typeof BulkSelectValue)[keyof typeof BulkSelectValue];

export interface BulkSelectProps extends Omit<DropdownProps, 'toggle' | 'onSelect'> {
/** BulkSelect className */
Expand Down Expand Up @@ -102,29 +102,27 @@ export const BulkSelect: React.FC<BulkSelectProps> = ({
onClick={onToggleClick}
aria-label="Bulk select toggle"
ouiaId={`${ouiaId}-toggle`}
splitButtonOptions={{
items: [
<MenuToggleCheckbox
ouiaId={`${ouiaId}-checkbox`}
id={`${ouiaId}-checkbox`}
key="bulk-select-checkbox"
aria-label={`Select ${allOption}`}
isChecked={
(isDataPaginated && pagePartiallySelected) ||
(!isDataPaginated && selectedCount > 0 && selectedCount < totalCount)
? null
: pageSelected || selectedCount === totalCount
}
onChange={(checked) => onSelect?.(!checked || checked === null ? noneOption : allOption)}
{...menuToggleCheckboxProps}
/>,
selectedCount > 0 ? (
<span onClick={onToggleClick} data-ouia-component-id={`${ouiaId}-text`} key="bulk-select-text">
{`${selectedCount} selected`}
</span>
) : null
]
}}
splitButtonItems={[
<MenuToggleCheckbox
ouiaId={`${ouiaId}-checkbox`}
id={`${ouiaId}-checkbox`}
key="bulk-select-checkbox"
aria-label={`Select ${allOption}`}
isChecked={
(isDataPaginated && pagePartiallySelected) ||
(!isDataPaginated && selectedCount > 0 && selectedCount < totalCount)
? null
: pageSelected || selectedCount === totalCount
}
onChange={(checked) => onSelect?.(!checked || checked === null ? noneOption : allOption)}
{...menuToggleCheckboxProps}
/>,
selectedCount > 0 ? (
<span onClick={onToggleClick} data-ouia-component-id={`${ouiaId}-text`} key="bulk-select-text">
{`${selectedCount} selected`}
</span>
) : null
]}
/>
)}
{...props}
Expand Down
4 changes: 2 additions & 2 deletions packages/module/src/ColumnManagementModal/ColumnManagementModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,11 @@ const ColumnManagementModal: React.FunctionComponent<ColumnManagementModalProps>
<DataListItem key={column.key}>
<DataListItemRow>
<DataListCheck
checked={column.isShown}
isChecked={column.isShown}
onChange={() => handleChange(index)}
isDisabled={column.isUntoggleable}
aria-labelledby={`${ouiaId}-column${index}-label`}
data-ouia-component-id={`${ouiaId}-column${index}-checkbox`}
ouiaId={`${ouiaId}-column${index}-checkbox`}
id={`${ouiaId}-column${index}-checkbox`}
/>
<DataListItemCells
Expand Down
6 changes: 3 additions & 3 deletions packages/module/src/MultiContentCard/__snapshots__/MultiContentCard.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ exports[`MultiContentCard component should render expandable multi-content card
type="button"
>
<span
class="pf-v6-c-button__icon pf-m-start"
class="pf-v6-c-button__icon"
>
<span
class="pf-v6-c-card__header-toggle-icon"
Expand Down Expand Up @@ -480,7 +480,7 @@ exports[`MultiContentCard component should render expandable multi-content card
type="button"
>
<span
class="pf-v6-c-button__icon pf-m-start"
class="pf-v6-c-button__icon"
>
<span
class="pf-v6-c-card__header-toggle-icon"
Expand Down Expand Up @@ -928,7 +928,7 @@ exports[`MultiContentCard component should render expandable multi-content card
type="button"
>
<span
class="pf-v6-c-button__icon pf-m-start"
class="pf-v6-c-button__icon"
>
<span
class="pf-v6-c-card__header-toggle-icon"
Expand Down
8 changes: 4 additions & 4 deletions packages/module/src/TagCount/__snapshots__/TagCount.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ exports[`TagCount component should render a disabled tag count with no value 1`]
type="button"
>
<span
class="pf-v6-c-button__icon pf-m-start"
class="pf-v6-c-button__icon"
>
<span
class="pf-v6-c-icon"
Expand Down Expand Up @@ -60,7 +60,7 @@ exports[`TagCount component should render a disabled tag count with no value 1`]
type="button"
>
<span
class="pf-v6-c-button__icon pf-m-start"
class="pf-v6-c-button__icon"
>
<span
class="pf-v6-c-icon"
Expand Down Expand Up @@ -160,7 +160,7 @@ exports[`TagCount component should render a tag count of 11 1`] = `
type="button"
>
<span
class="pf-v6-c-button__icon pf-m-start"
class="pf-v6-c-button__icon"
>
<span
class="pf-v6-c-icon"
Expand Down Expand Up @@ -205,7 +205,7 @@ exports[`TagCount component should render a tag count of 11 1`] = `
type="button"
>
<span
class="pf-v6-c-button__icon pf-m-start"
class="pf-v6-c-button__icon"
>
<span
class="pf-v6-c-icon"
Expand Down
2 changes: 1 addition & 1 deletion packages/module/src/WarningModal/__snapshots__/WarningModal.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ exports[`WarningModal component should render 1`] = `
type="button"
>
<span
class="pf-v6-c-button__icon pf-m-start"
class="pf-v6-c-button__icon"
>
<svg
aria-hidden="true"
Expand Down
22 changes: 11 additions & 11 deletions packages/module/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ export * from './WarningModal';
export { default as UnavailableContent } from './UnavailableContent';
export * from './UnavailableContent';

export { default as UnauthorizedAccess } from './UnauthorizedAccess';
export * from './UnauthorizedAccess';

export { default as TagCount } from './TagCount';
export * from './TagCount';

Expand All @@ -21,21 +24,21 @@ export * from './Shortcut';
export { default as ServiceCard } from './ServiceCard';
export * from './ServiceCard';

export { default as PageHeader } from './PageHeader';
export * from './PageHeader';

export { default as NotFoundIcon } from './NotFoundIcon';
export * from './NotFoundIcon';

export { default as UnauthorizedAccess } from './UnauthorizedAccess';
export * from './UnauthorizedAccess';

export { default as MultiContentCard } from './MultiContentCard';
export * from './MultiContentCard';

export { default as LogSnippet } from './LogSnippet';
export * from './LogSnippet';

export { default as MissingPage } from './MissingPage';
export * from './MissingPage';

export { default as LogSnippet } from './LogSnippet';
export * from './LogSnippet';

export { default as HorizontalNav } from './HorizontalNav';
export * from './HorizontalNav';

Expand All @@ -54,9 +57,6 @@ export * from './DetailsPageHeader';
export { default as DetailsPage } from './DetailsPage';
export * from './DetailsPage';

export { default as PageHeader } from './PageHeader';
export * from './PageHeader';

export { default as ColumnManagementModal } from './ColumnManagementModal';
export * from './ColumnManagementModal';

Expand All @@ -69,8 +69,8 @@ export * from './BulkSelect';
export { default as Battery } from './Battery';
export * from './Battery';

export { default as Ansible } from './AnsibleSupport';
export * from './AnsibleSupport';
export { default as Ansible } from './Ansible';
export * from './Ansible';

export { default as ActionMenu } from './ActionMenu';
export * from './ActionMenu';
Expand Down
Loading
Loading