Skip to content

fix: allow React node in ContentHeader #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhlavac merged 2 commits into from
Jan 14, 2025
Merged

fix: allow React node in ContentHeader #543

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9006e8a
fix: allow React node in ContentHeader
fhlavac Jan 13, 2025
e1cb330
Update packages/module/src/ContentHeader/ContentHeader.tsx
fhlavac Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions packages/module/src/ContentHeader/ContentHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ export interface PageHeaderLinkProps extends ButtonProps {

export interface ContentHeaderProps extends React.PropsWithChildren {
/** Title for content header */
title: string;
title: React.ReactNode;
/** Optional subtitle for content header */
subtitle?: string;
subtitle?: React.ReactNode;
/** Optional link below subtitle */
linkProps?: PageHeaderLinkProps;
/** Optional icon for content header (appears to the left of the content header's title with a divider) */
Expand All @@ -51,7 +51,7 @@ const useStyles = createUseStyles({

export const ContentHeader: React.FunctionComponent<React.PropsWithChildren<ContentHeaderProps>> = ({
title,
subtitle,
subtitle = null,
linkProps,
icon,
label,
Expand All @@ -64,7 +64,7 @@ export const ContentHeader: React.FunctionComponent<React.PropsWithChildren<Cont

return (
<PageSection variant="light">
{ breadcrumbs && (
{breadcrumbs && (
<div className="pf-v5-u-mb-md">
{breadcrumbs}
</div>
Expand All @@ -84,9 +84,11 @@ export const ContentHeader: React.FunctionComponent<React.PropsWithChildren<Cont
<Split hasGutter>
<SplitItem>
<TextContent>
<Text className="pf-v5-u-mb-sm" component="h1" ouiaId={`${ouiaId}-title`}>
{title}
</Text>
{typeof title === 'string' ? (
<Text className="pf-v5-u-mb-sm" component="h1" ouiaId={`${ouiaId}-title`}>
{title}
</Text>
) : title}
</TextContent>
</SplitItem>
{label && (
Expand All @@ -102,13 +104,21 @@ export const ContentHeader: React.FunctionComponent<React.PropsWithChildren<Cont
)}
</Split>
<TextContent>
{subtitle && (
{typeof subtitle === 'string' ? (
<Text component="p" ouiaId={`${ouiaId}-subtitle`}>
{subtitle}
</Text>
)}
) : subtitle}
{linkProps && (
<Button variant={ButtonVariant.link} component="a" ouiaId={`${ouiaId}-link-button`} isInline icon={linkProps.isExternal ? <ExternalLinkAltIcon className='pf-v5-u-ml-sm' /> : null} iconPosition="end" {...linkProps}>
<Button
variant={ButtonVariant.link}
component="a"
ouiaId={`${ouiaId}-link-button`}
isInline
icon={linkProps.isExternal ? <ExternalLinkAltIcon className='pf-v5-u-ml-sm' /> : null}
iconPosition="end"
{...linkProps}
>
{linkProps.label}
</Button>
)}
Expand All @@ -117,6 +127,7 @@ export const ContentHeader: React.FunctionComponent<React.PropsWithChildren<Cont
</Flex>
{children}
</PageSection>
)};
);
};

export default ContentHeader;
Loading