Skip to content

Conversation

@epwinchell
Copy link
Collaborator

@epwinchell epwinchell commented Jan 27, 2025

Jira: https://issues.redhat.com/browse/RHCLOUD-36480

  • Includes initial install of Emotion

Screenshot 2025-01-27 at 3 44 20 PM
Screenshot 2025-01-27 at 3 44 28 PM

@epwinchell epwinchell changed the title Convert 'MultiContentCard' and "ServiceCard' to emotion chore: Convert 'MultiContentCard' and "ServiceCard' to emotion Jan 27, 2025
@patternfly-build
Copy link

patternfly-build commented Jan 27, 2025

@epwinchell epwinchell requested a review from fhlavac January 27, 2025 20:50
@@ -1,3 +1,5 @@
/** @jsx jsx */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a way of getting rid of these annotations

Copy link
Collaborator Author

@epwinchell epwinchell Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fhlavac We get test failures without that line.
(updated to use /** @jsxImportSource @emotion/react */ )
See: https://emotion.sh/docs/css-prop#jsx-pragma

@epwinchell epwinchell marked this pull request as draft January 30, 2025 15:17
@epwinchell epwinchell closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants