fix(PageHeader): reduce margins in breadcrumb #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
packages/module/src/PageHeader/PageHeader.tsx:70
- Replacing the outer with a fragment removes the default styling and layout spacing provided by PageSection. Verify that the new structure still meets the desired design and spacing requirements.
<>
| }: PageHeaderProps) => { | ||
| const classes = useStyles(); | ||
| const { isExternal = false, ...linkRestProps } = linkProps ?? {}; | ||
| const showSplitRow = title || label || actionMenu; |
There was a problem hiding this comment.
The variable 'actionMenu' is used in the condition but is not declared in the PageHeaderProps interface, which could lead to runtime errors. Consider either removing it or adding it as an optional prop.
nicolethoen
approved these changes
Apr 15, 2025
|
🎉 This PR is included in version 6.2.0-prerelease.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes excess spacing in breadcrumbs in PageHeader component group. also makes all props optional--OCP has a usecase where no props are passed to the PageHeader, so it should render as a regular PageSection in this case.