Skip to content

chore(ci-release): trigger a release #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wise-king-sullyman merged 2 commits into from
May 22, 2025
Merged

chore(ci-release): trigger a release #93

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bb317d
chore(ci-release): trigger a release
parthivrh May 21, 2025
6fda8fa
chore(typo): Addressed review comment by fixing missing space
parthivrh May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/module/patternfly-docs/content/examples/basic.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,4 @@ The following example demonstrates how to use the `async` function to send data
To customize the content displayed in the feedback modal, pass in a custom `i18n` object with values for each property of`<FeedbackModal>`. This allows you to prepare a modal for different languages and requirements.
Copy link

@mcoker mcoker May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To customize the content displayed in the feedback modal, pass in a custom `i18n` object with values for each property of`<FeedbackModal>`. This allows you to prepare a modal for different languages and requirements.
To customize the content displayed in the feedback modal, pass in a custom `i18n` object with values for each property of `<FeedbackModal>`. This allows you to prepare a modal for different languages and requirements.

Just noticed there is a space missing here, so maybe this can be the whitespace change needed to trigger a release? Also I'm not sure if this repo uses semantic release messages, but if it does chore() will not initiate a release. fix() will issue a patch release (eg 1.2.3 -> 1.2.4) and feat() will issue a minor/feature release (eg 1.2.3 -> 1.3.0)

Copy link
Contributor

@dlabaj dlabaj May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does use semantic release. Can you update the git commit to use fix: Other then @mcoker comment. lgtm. Thanks @parthivrh

Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcoker @dlabaj this is one of the repos where I have some custom release rules in the semantic release config file so chore(ci-release) should issue a patch release.

This is semantic-release though so anything is possible.

```js file="./i18n.tsx"

```
```