Skip to content

Enable external client management#38

Merged
patvice merged 3 commits intopatvice:mainfrom
MadBomber:enable_external_client_management
Jul 7, 2025
Merged

Enable external client management#38
patvice merged 3 commits intopatvice:mainfrom
MadBomber:enable_external_client_management

Conversation

@MadBomber
Copy link
Contributor

I also implemented the business logic for the @client as an Array but ran out of time trying to figure out the test suite. It had no provisions for running the MCP servers found in the fixtures directory. I may come back to that later unless you already have a solution.

MadBomber added 2 commits July 6, 2025 22:17
Updated the `RubyLLM::MCP.client` method to create a new client
instance each time it's called. This allows for better management
of multiple MCP clients with varying configurations instead of
returning a single memoized instance, enhancing the flexibility
for applications needing concurrent client handling.

Additionally, added a new document outlining the capabilities
and usage patterns for managing multiple clients effectively.
@@ -0,0 +1,342 @@
# Managing Multiple MCP Clients
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While interesting - I feel like this should be taken into docs (which are coming) instead of a .md file in the root of the project

@patvice
Copy link
Owner

patvice commented Jul 7, 2025

Hey @MadBomber - I'm going to reduce the readme contributions here and pop off the extra .md. I don't mind the content but probably belongs in a docs/guides which will be coming for a v1 release, so save this for later and move this out for the time being.

@patvice patvice merged commit 436bb82 into patvice:main Jul 7, 2025
9 of 10 checks passed
@patvice
Copy link
Owner

patvice commented Jul 7, 2025

Thanks for the contribution @MadBomber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants