Skip to content

Object only can a key with the same name, rates type string cannot be a number #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alan966 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Object only can a key with the same name, rates type string cannot be a number #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ class CurrencyConverter {
"FCFA": "Central African CFA Franc",
"CLP": "Chilean Peso",
"CLF": "Chilean Unit of Account (UF)",
"CNY": "Chinese Yuan",
"CNY": "Chinese Yuan (offshore)",
"CNY": ["Chinese Yuan", "Chinese Yuan (offshore)"],
"COP": "Colombian Peso",
"KMF": "Comorian Franc",
"CDF": "Congolese Franc",
Expand Down Expand Up @@ -294,11 +293,11 @@ class CurrencyConverter {
if (rates.includes(","))
rates = this.replaceAll(rates, ",", "")
}
rates = parseFloat(rates) / this.currencyAmount
const rates_number = rates = parseFloat(rates) / this.currencyAmount
if (this.isRatesCaching) {
this.addRateToRatesCache(currencyPair, rates);
this.addRateToRatesCache(currencyPair, rates_number);
}
return rates
return rates_number;
})
}
}
Expand Down