Open
Conversation
Fills out _get_pathlib_object Renames _get_pathlib_object as _sanitize_file_path
Owner
|
Looks good in as much as it does everything what I said it should do. However, I don't think that my specifications were particularly bright to begin with. Specifically, checking if the file/parent directory exists is probably superfluous, as the the read/write function being wrapped will do that anyway. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fills out _get_pathlib_object
Renames _get_pathlib_object as _sanitize_file_path
Pathlib will already determine the os that it's being run on and should return the correct Path type for the os when converted to 'str()'
Haven't had a chance to test this as I'm not on the computer I was using for scoring, not sure best way to test it?
Also, not the best when it comes to documentation, any tips welcome.