Merged
Conversation
…nent handling Introduce `FilterBarConfiguration` enum to represent default or custom configurations, providing helper methods for component access and conversion. Update `FilterBarConfigView` to use the new enum, removing direct dependency on `AppSettings`. Adjust state initialization, reset logic, and bindings to work with the enum. Update animations and change handlers to reference `AppSettings.shared.filterBarConfiguration`. Modify `AppSettings` to store the new enum type, defaulting to `.default`.
* Introduce `configuredComponents` array to expose the filter bar components that should be displayed. * Extract component rendering into `componentView(_:)` for each `FilterBarComponent`. * Replace the long hard‑coded list of elements with a single `ForEach` over `configuredComponents`. * Remove legacy iOS 18‑specific view (`barContentiOS18`) and use the unified `barContent` instead. * Add `RouteManager.shared` to the view environment for navigation support. * Clean up duplicated code and keep transitions, haptics, and animations consistent across all components.
Move `FilterBarComponent` and `FilterBarConfiguration` definitions from the Settings view into the core Model folder.
Synchronize UserDefaults immediately after updating the filter bar configuration to ensure changes persist across app launches.
paulgessinger
force-pushed
the
feat/configurable-filter-bar
branch
from
0064230 to
b7ee7fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes
filterBarConfigurationstruct with a newFilterBarConfigurationenum to simplify component handling and provide helper methods.FilterBarConfigViewto use the new enum, removing direct dependency onAppSettings.configuredComponentsarray, extracted component rendering intocomponentView(_:), and replaced hard‑coded element lists with a singleForEach.barContentiOS18) and unified tobarContent.RouteManager.sharedto the view environment for navigation support.FilterBarComponentandFilterBarConfigurationdefinitions to the core Model module.