[actions] restrict permissions#479
Conversation
|
@ljharb Please take a look for this PR. |
ljharb
left a comment
There was a problem hiding this comment.
Dependabot is one of the worst updating tools; if anything I'd do renovate.
Separately, pinning actions imo is a harmful idea, especially since there can be precisely zero collateral damage from all of these workflows being compromised - which means there's precisely zero benefit from pinning them, and multiple downsides.
I'm happy to take the explicit permission changes, though.
|
Thanks for reply! For the sake of a clean commit log, I’ll open a new PR that focuses solely on the permissions changes later if you'd prefer to unpin the dependencies. |
.github/workflows/rebase.yml
Outdated
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/checkout@v2.7.0 |
There was a problem hiding this comment.
please revert this as well, there’s no benefit from pinning to a minor version (ever)
|
|
||
| steps: | ||
| - uses: ljharb/require-allow-edits@main | ||
| - uses: ljharb/require-allow-edits@13f90bc8cc5de000f2b44a0e2c3a11d108e8cd9f # main |
|
That vulnerability only matters when there’s a privileged token present - and most CI jobs don’t have any, including these. |
|
OK. Thanks for your patience. I have reset the redundancy log and committed force only including restricting permissions. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files@@ Coverage Diff @@
## master #479 +/- ##
===========================================
- Coverage 85.84% 30.16% -55.68%
===========================================
Files 2 2
Lines 2360 2360
Branches 614 614
===========================================
- Hits 2026 712 -1314
- Misses 334 1648 +1314 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I accidentally pushed the test commits for Renovate to the upstream repository. Sorry about that — I'll figure out a way to remove them later. |
|
@ljharb Hi! The CI workflow has completed successfully. Could you please merge this branch? Thanks! |
Hi. I'd like to suggest some security enhancements. In this PR, I change the configurations of actions:
Here are the two corresponding security risks for each of them:
If you’re interested, I’d be happy to discuss these security risks with you.