perf: invert points in edwards.sign() at once#224
Draft
ChALkeR wants to merge 1 commit intopaulmillr:mainfrom
Draft
perf: invert points in edwards.sign() at once#224ChALkeR wants to merge 1 commit intopaulmillr:mainfrom
ChALkeR wants to merge 1 commit intopaulmillr:mainfrom
Conversation
ChALkeR
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PoC, ignore types
~12% speedup in
ed25519.sign()on Node.js without API changes in that methodDoes this pose a timing risk?
If this works and is safe, an actual impl could be not specific to 2 points and just e.g. take an array of scalars as input (and perhaps even return
toBytes()already)