perf: another tiny improvement in scrypt#123
Draft
ChALkeR wants to merge 1 commit intopaulmillr:mainfrom
Draft
Conversation
ChALkeR
changed the title
Owner
|
and how does that compare now? |
ChALkeR
force-pushed
the
chalker/perf/scrypt/1
branch
from
53f0b42 to
ca98810
Compare
Contributor
Author
|
will recheck perf, do not merge yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #122
I observe another 2.5% improvement on v8
i.e. setting
AtoBand then doingA[i] ^= C[i]in a loop seems to be faster thanA[i] = B[i] ^ C[i]The outer
V0.setis just for clarity, it doesn't affect perfWill recheck on other engines once #122 gets in