Fix ecdhKem.encapsulate default rand length#35
Merged
paulmillr merged 1 commit intopaulmillr:mainfrom Dec 22, 2025
Merged
Conversation
Currently, trying to use encapsulate() without an explicit rand throws
"seed" expected Uint8Array of length 48, got length=32
All the internal callsites pass rand explicitly.
Contributor
Author
|
Feel free to toss the PR if you want to do a more complete fix, add tests, anything. It was just easier to patch than to explain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, trying to use encapsulate() without an explicit rand throws
All the internal callsites pass rand explicitly.