This repository was archived by the owner on Dec 21, 2018. It is now read-only.
Updating plugin to work with CakePHP 3#18
Open
akkaweb wants to merge 1 commit intopaulredmond:masterfrom
Open
Conversation
Author
|
Also, I wanted to bring up to you that, this is my first ever Pull Request. I noticed it says "akkaweb wants to merge 1 commit into paulredmond:master from akkaweb:akkaweb/3.0". However, that is not my intention as this is a totally new branch. Not just some changes. You can do how you feel is right. |
Owner
|
@akkaweb sweet. I've been focused more on Laravel lately, so I will keep an eye on this PR once you get test coverage and passing CI build I will review it. Thanks! |
Author
|
@paulredmond I should be able to create those tests this weekend. I will keep you posted. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to use this great plugin in my applications that use CakePHP 3 to take advantage of Chosen. Since a 3.0 version was not yet available and instead of waiting or creating another, I decided to just upgrade this to work with CakePHP 3. I have been using it in my applications and I will continue using it everything I need. Before moving foward with more additions, I wanted to bring this up to you, so you can look into it to make sure I am heading in the right direction. I have updated the README file to reflect these changes and make sure users can set the plugin successfully. TestCases are yet to be created.