Update to Python 3.14 #160
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR raises the project’s baseline to Python 3.14 across build, CI, and development environments.
- Bumps requires-python to >=3.14 and updates Docker base image and devcontainer to Python 3.14
- Updates GitHub Actions to run on Python 3.14
- Aligns internal docs to indicate Python 3.14+
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Sets minimum supported Python to 3.14 to enforce runtime baseline. |
| Dockerfile | Switches uv base image to Python 3.14 for container builds. |
| .python-version | Updates local toolchain version to 3.14. |
| .github/workflows/ci.yml | Runs CI with Python 3.14. |
| .github/copilot-instructions.md | Updates documentation to reflect Python 3.14+. |
| .devcontainer/devcontainer.json | Uses devcontainer image with Python 3.14. |
| "name": "Python 3", | ||
| // Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile | ||
| "image": "mcr.microsoft.com/devcontainers/python:1-3.13-bullseye", | ||
| "image": "mcr.microsoft.com/devcontainers/python:1-3.14-bullseye", |
There was a problem hiding this comment.
The devcontainer uses Debian bullseye while the Dockerfile base is bookworm-slim; this divergence can cause environment inconsistencies. Recommend aligning to bookworm to match the Dockerfile: mcr.microsoft.com/devcontainers/python:1-3.14-bookworm.
| "image": "mcr.microsoft.com/devcontainers/python:1-3.14-bullseye", | |
| "image": "mcr.microsoft.com/devcontainers/python:1-3.14-bookworm", |
| @@ -1,4 +1,4 @@ | |||
| ARG python_version=3.13 | |||
| ARG python_version=3.14 | |||
There was a problem hiding this comment.
[nitpick] For reproducible builds, consider pinning to a patch version (e.g., 3.14.0) instead of a floating minor (3.14). This avoids unexpected changes when new 3.14.x patch releases land.
| ARG python_version=3.14 | |
| ARG python_version=3.14.0 |
| @@ -1 +1 @@ | |||
| 3.13 | |||
| 3.14 | |||
There was a problem hiding this comment.
[nitpick] Consider pinning to a patch version (e.g., 3.14.0) for consistency with pyenv/asdf resolutions and to make local environments deterministic.
| 3.14 | |
| 3.14.0 |
| uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: '3.13' | ||
| python-version: '3.14' |
There was a problem hiding this comment.
[nitpick] CI could use '3.14.x' to always pick the latest patch within 3.14, or pin to '3.14.0' for full reproducibility—pick one strategy and apply consistently. Using '3.14.x' is a common balance between stability and security updates.
| uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: '3.13' | ||
| python-version: '3.14' |
There was a problem hiding this comment.
[nitpick] Mirror the chosen strategy from the other job ('3.14.x' or a specific patch like '3.14.0') so both jobs resolve Python identically.
1 participant
No description provided.