Skip to content

Randomly #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Ci314t - Faster CI w/ sccache and xdist
wants to merge 43 commits into from
Closed

Randomly #11

wants to merge 43 commits into from

Conversation

@paultiq
Copy link
Owner

@paultiq paultiq commented Sep 17, 2025 •
edited
Loading

This PR adds (and fixes) tests under a mix of different scenarios:

  • Random order, using pytest-randomly: To detect test order dependencies. This was observed in a few tests that created tables with the same name
  • Multiprocessing using pytest-xdist: Runs tests concurrently in separate processes. This should be a non-issue for duckdb, provided tests properly use tmp_path/tmp_file fixtures for test-specific directories.
  • Threading using pytest-run-parallel: Many tests are not thread-safe, due to the concurrent use of the default connection.

paultiq and others added 30 commits September 16, 2025 07:05
@paultiq
chore: Add 3.14 and 3.14t builds: update GHA matrix, bump uv and cibu…
d6c8779 
…ildwheel to include 3.14rc2, and handle new pandas warning, and mark unsupported packages as < 3.14.
@paultiq
chore: remove pandas 3.0 warnings -> instead, disable pandas for 3.14…
69415c1 
… for now.
@paultiq
test: Disable Pandas for 3.14
ded40ec 
Not yet available
@paultiq
test: disable failing test "Windows fatal exception: access violation"
2ad0350
@paultiq
tests: skip, don't xfail
557df24
@paultiq
exclude Windows
b4e404e
@paultiq
tests: revert the skip since we're excluding Windows 3.14t builds ent…
a540862 
…irely.
@paultiq
revert: import that was added, no longer needed
3f8c7d7
@paultiq
revert: exactly to original
8b11bc4
@paultiq
test: Mark test xfail
6c35985
@paultiq
test: mark test xfail
64b70d6
@paultiq
chore: Add comments and todo's for workflow changes
80c57b0
@paultiq
chore: Remove unused section for Windows 3.14t builds.
e315bb7
@paultiq
chore: Add version check to only allow no-Pandas for 3.14, plus a TODO
fd26187
@paultiq
tests: Narrow pandas not installed skip to duckdb.InvalidInputException
6044ea0
@paultiq
tests: revert xfail for 3.14 now that duckdb#48 is merged
d899bcf
@evertlammerts
Merge branch 'main' into ci314t
889699b
@evertlammerts
Python 3.14 / 3.14t builds (duckdb#50)
83d839c 
Per [Discussion: Python 3.14 Free-Threading
Support](duckdb#40), this
is the first step / pre-requisite for free-threading work.

This PR adds Python 3.14 & 3.14t (rc2) builds, with a test change to
handle not-yet-available dependencies.

#### Free Threading is not enabled by this
Free threading is **not** implemented here. If DuckDB is imported in
3.14t, the GIL is enabled with the following warning:
> `<frozen importlib._bootstrap>:491: RuntimeWarning: The global
interpreter lock (GIL) has been enabled to load module '_duckdb', which
has not declared that it can run safely without the GIL. To override
this behavior and keep the GIL disabled (at your own risk), run with
PYTHON_GIL=0 or -Xgil=0.`

#### Timeline
- Python 3.14 is scheduled to release on 2025-10-07: [PEP 745 – Python
3.14 Release Schedule](https://peps.python.org/pep-0745/)
- In 3.14, [PEP 779: Free-threaded Python is officially
supported](https://docs.python.org/3.14/whatsnew/3.14.html#pep-779-free-threaded-python-is-officially-supported)

#### Changes
- Update uv to 0.8.16 and cibuilwheel to 3.1.x: needed for the latest
Python builds
- Added Windows specific build flags for 3.14t
- Add markers to disable dependencies that don't yet support 3.14

#### Notes:
- Windows + 3.14t is excluded: tests fail in the CI workflow, yet work
locally & in a modified workflow. Root cause is unknown.
- Marked xfailed duckdb#48
@evertlammerts
Packaging workflow should respect the 'minimal' input param
c535a23
@paultiq
tests: Use a unique file for each database, for concurrent test isola…
c592c6e 
…tion
@paultiq
tests: pytest plugins: randomly to randomize order, xdist for multipr…
624891b 
…ocessing, run-parallel for multi-threaded
@paultiq
tests: using a tmp_path_factory for concurrent testing
1d39069
@paultiq
tests: add a 2 minute test timeout. Tests can override this with @pyt…
b21a5bf 
…est.mark.timeout(60)
@paultiq
tests: 2 minutes
98f3668
@paultiq
tests: modify tests to be threading safe *or* explicitly marked as un…
f6e0cd9 
…safe
@paultiq
revert
c0ec7f1
@paultiq
tests: add workflow to do random, multiprocess and multithreaded tests.
8d8e06e
@paultiq
tests: Use unique table names for each test so tests can run in any o…
fc1538d 
…rder
@paultiq
tests: Move the slow 10M test to tests/slow
45e7ae3
@paultiq
tests: use tmp_path so each test gets unique test.db
543654b
@paultiq paultiq closed this Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paultiq @evertlammerts