Skip to content

Make it works with custom inheritance column name#1213

Merged
excid3 merged 5 commits intopay-rails:mainfrom
gabriel-curtino:main
Dec 23, 2025
Merged

Make it works with custom inheritance column name#1213
excid3 merged 5 commits intopay-rails:mainfrom
gabriel-curtino:main

Conversation

@gabriel-curtino
Copy link
Contributor

@gabriel-curtino gabriel-curtino commented Dec 13, 2025

Pull Request

Summary:
Replacing the hardcoded type attr name in the queries with the actual inherithance column name.

Testing:
Didn't add an specific test for testing it with custom inheritance columns names.

Checklist:

  • Code follows the project's coding standards
  • Tests have been added or updated to cover the changes
  • Documentation has been updated (if applicable)
  • All existing tests pass
  • Conforms to the contributing guidelines

Additional Notes:

Added an extra where clause because otherwise standardrb complains about the style: lib/pay/attributes.rb:98:46: Style/HashSyntax: Don't mix styles in the same hash.

@gabriel-curtino gabriel-curtino changed the title Make set_merchant_processor works with the actual inheritance column name Make it works with custom inheritance column name Dec 13, 2025
@excid3 excid3 merged commit 0353aba into pay-rails:main Dec 23, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants